From 74732cc0d8ab8d5327f0bdc4da2817a02abee8a5 Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Mon, 13 Apr 2015 17:12:06 +0200 Subject: [PATCH] Fix user list * the name cell was changed from td to th because of accessibility issues - this adjusts the CSS and JS to behave like before --- settings/css/settings.css | 5 +++++ settings/js/users/users.js | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/settings/css/settings.css b/settings/css/settings.css index 747e370617e..f610e96eea8 100644 --- a/settings/css/settings.css +++ b/settings/css/settings.css @@ -138,6 +138,11 @@ span.usersLastLoginTooltip { white-space: nowrap; } display : none; } +/* because of accessibility the name cell is - therefore we enforce the black color */ +#userlist th.name { + color: #000000; +} + tr:hover>td.password>span, tr:hover>td.displayName>span { margin:0; cursor:pointer; } tr:hover>td.remove>a, tr:hover>td.password>img,tr:hover>td.displayName>img, tr:hover>td.quota>img { visibility:visible; cursor:pointer; } td.remove { diff --git a/settings/js/users/users.js b/settings/js/users/users.js index e67540fd117..4b46bbf898f 100644 --- a/settings/js/users/users.js +++ b/settings/js/users/users.js @@ -74,7 +74,7 @@ var UserList = { $tr.data('displayname', user.displayname); $tr.data('mailAddress', user.email); $tr.data('restoreDisabled', user.isRestoreDisabled); - $tr.find('td.name').text(user.name); + $tr.find('.name').text(user.name); $tr.find('td.displayName > span').text(user.displayname); $tr.find('td.mailAddress > span').text(user.email); @@ -259,8 +259,8 @@ var UserList = { rows.sort(function(a, b) { // FIXME: inefficient way of getting the names, // better use a data attribute - a = $(a).find('td.name').text(); - b = $(b).find('td.name').text(); + a = $(a).find('.name').text(); + b = $(b).find('.name').text(); var firstSort = UserList.preSortSearchString(a, b); if(typeof firstSort !== 'undefined') { return firstSort; -- 2.39.5