From 758a08fad9c9da5a8378bcde2cd29608b6127741 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Tue, 21 Jan 2020 04:02:53 +0000 Subject: [PATCH] Use existing scopes instead of one-off AR condition (#32628). Patch by Jan Schulz-Hofen. git-svn-id: http://svn.redmine.org/redmine/trunk@19446 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/issue_priority.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/issue_priority.rb b/app/models/issue_priority.rb index 106754293..05be79dd1 100644 --- a/app/models/issue_priority.rb +++ b/app/models/issue_priority.rb @@ -50,7 +50,7 @@ class IssuePriority < Enumeration # Updates position_name for active priorities # Called from migration 20121026003537_populate_enumerations_position_name def self.compute_position_names - priorities = where(:active => true).sort_by(&:position) + priorities = active if priorities.any? default = priorities.detect(&:is_default?) || priorities[(priorities.size - 1) / 2] priorities.each_with_index do |priority, index| -- 2.39.5