From 75abdef0c27dc443aaa4f05c2e868119887afb3c Mon Sep 17 00:00:00 2001 From: Stas Vilchik Date: Wed, 4 Apr 2018 08:43:42 +0200 Subject: [PATCH] SONAR-9697 Ensure tooltips are always placed correctly (#77) --- server/sonar-web/package.json | 1 - .../ComponentNavBranch-test.tsx.snap | 3 - .../ComponentNavBranchesMenu-test.tsx.snap | 2 - .../ComponentNavMeta-test.tsx.snap | 1 - .../app/components/nav/global/GlobalNav.tsx | 32 +- .../src/main/js/app/styles/sonar.css | 1 - .../js/apps/account/projects/ProjectCard.tsx | 18 +- .../__snapshots__/Workers-test.tsx.snap | 9 - .../components/ActivationFormModal.tsx | 8 +- .../components/RuleDetailsIssues.tsx | 4 +- .../coding-rules/components/RuleListItem.tsx | 2 +- .../components/Breadcrumb.js | 10 +- .../components/LeakPeriodLegend.js | 6 +- .../components/MeasureHeader.js | 4 +- .../__snapshots__/Breadcrumb-test.js.snap | 22 +- .../LeakPeriodLegend-test.js.snap | 1 - .../__snapshots__/MeasureHeader-test.js.snap | 2 - .../ConciseIssueLocationBadge-test.tsx.snap | 1 - .../__snapshots__/PluginLicense-test.tsx.snap | 1 - .../ApplicationLeakPeriodLegend.tsx | 6 +- .../overview/components/LeakPeriodLegend.js | 2 +- .../ApplicationLeakPeriodLegend-test.tsx | 2 +- .../ApplicationLeakPeriodLegend-test.tsx.snap | 6 +- .../main/js/apps/overview/events/Analysis.tsx | 2 +- .../main/js/apps/overview/events/Event.tsx | 4 +- .../__snapshots__/Analysis-test.tsx.snap | 1 - .../__snapshots__/Event-test.tsx.snap | 1 - .../main/js/apps/overview/main/enhance.tsx | 2 +- .../__snapshots__/QualityGate-test.js.snap | 1 - .../components/GraphsLegendCustom.js | 3 +- .../components/ProjectActivityAnalysis.js | 2 +- .../GraphsLegendCustom-test.js.snap | 1 - .../ProjectActivityAnalysesList-test.js.snap | 4 - .../components/ProjectCardLanguages.tsx | 2 +- .../projects/components/ProjectCardLeak.tsx | 4 +- .../components/ProjectCardOverall.tsx | 4 +- .../__snapshots__/PageHeader-test.tsx.snap | 1 - .../ProjectCardLanguages-test.tsx.snap | 4 - .../ProjectCardQualityGate-test.tsx.snap | 1 - .../ProjectsSortingSelect-test.tsx.snap | 3 - .../__snapshots__/Search-test.tsx.snap | 2 - .../components/BuiltInQualityGateBadge.tsx | 2 +- .../components/BuiltInQualityProfileBadge.tsx | 8 +- ...rofileRulesDeprecatedWarning-test.tsx.snap | 1 - ...ofileRulesSonarWayComparison-test.tsx.snap | 1 - .../components/info-items/HealthItem.tsx | 4 +- .../__snapshots__/HealthItem-test.tsx.snap | 1 - .../js/apps/web-api/components/Search.tsx | 4 +- .../__snapshots__/Search-test.tsx.snap | 2 - .../apps/webhooks/components/PageActions.tsx | 4 +- .../__snapshots__/PageActions-test.tsx.snap | 1 - .../main/js/components/charts/BubbleChart.js | 6 +- .../main/js/components/charts/Histogram.tsx | 22 +- .../main/js/components/charts/TreeMapRect.js | 13 +- .../__snapshots__/BubbleChart-test.js.snap | 204 +++++++------ .../__snapshots__/Histogram-test.tsx.snap | 126 ++++---- .../main/js/components/charts/bar-chart.js | 18 +- .../js/components/common/BranchStatus.tsx | 3 +- .../main/js/components/common/CodeSnippet.tsx | 2 +- .../js/components/common/PrivateBadge.tsx | 7 +- .../js/components/common/SelectListItem.js | 14 +- .../__snapshots__/BranchStatus-test.tsx.snap | 1 - .../__snapshots__/CodeSnippet-test.tsx.snap | 128 +++++--- .../__snapshots__/PrivateBadge-test.tsx.snap | 1 - .../__snapshots__/SelectListItem-test.js.snap | 88 +++--- .../components/controls/ClipboardButton.tsx | 29 +- .../js/components/controls/FavoriteBase.tsx | 2 +- .../js/components/controls/HomePageSelect.tsx | 2 +- .../js/components/controls/RadioToggle.tsx | 8 +- .../main/js/components/controls/Tooltip.css | 117 ++++++++ .../main/js/components/controls/Tooltip.tsx | 282 +++++++++++++++++- .../__tests__/ClipboardButton-test.tsx | 2 +- .../controls/__tests__/Tooltip-test.tsx | 70 +++++ .../ClipboardButton-test.tsx.snap | 36 ++- .../__snapshots__/FavoriteBase-test.tsx.snap | 2 - .../HomePageSelect-test.tsx.snap | 2 - .../__snapshots__/RadioToggle-test.tsx.snap | 26 +- .../__snapshots__/Tooltip-test.tsx.snap | 73 +++++ .../main/js/components/facet/FacetHeader.tsx | 2 +- .../components/intl/DateTooltipFormatter.tsx | 8 +- .../components/intl/TimeTooltipFormatter.tsx | 8 +- .../issue/components/IssueChangelog.js | 5 +- .../issue/components/IssueTitleBar.js | 3 +- .../__snapshots__/IssueChangelog-test.js.snap | 2 - .../__snapshots__/Measure-test.tsx.snap | 1 - server/sonar-web/tsconfig.json | 1 - server/sonar-web/yarn.lock | 105 +------ 87 files changed, 1015 insertions(+), 618 deletions(-) create mode 100644 server/sonar-web/src/main/js/components/controls/Tooltip.css create mode 100644 server/sonar-web/src/main/js/components/controls/__tests__/Tooltip-test.tsx create mode 100644 server/sonar-web/src/main/js/components/controls/__tests__/__snapshots__/Tooltip-test.tsx.snap diff --git a/server/sonar-web/package.json b/server/sonar-web/package.json index 6c553106d10..eadf694d63a 100644 --- a/server/sonar-web/package.json +++ b/server/sonar-web/package.json @@ -21,7 +21,6 @@ "keymaster": "1.6.2", "lodash": "4.17.4", "prop-types": "15.6.0", - "rc-tooltip": "3.5.0", "react": "16.2.0", "react-day-picker": "7.1.2", "react-dom": "16.2.0", diff --git a/server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavBranch-test.tsx.snap b/server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavBranch-test.tsx.snap index 498d9568f8c..42bc367a274 100644 --- a/server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavBranch-test.tsx.snap +++ b/server/sonar-web/src/main/js/app/components/nav/component/__tests__/__snapshots__/ComponentNavBranch-test.tsx.snap @@ -21,7 +21,6 @@ exports[`renders main branch 1`] = `
{ }, 3000); }; - withTutorialTooltip = (element: React.ReactNode) => - this.state.onboardingTutorialTooltip ? ( - - {element} - - ) : ( - element - ); - render() { return ( - + @@ -129,15 +120,22 @@ class GlobalNav extends React.PureComponent { @@ -146,8 +144,8 @@ class GlobalNav extends React.PureComponent { )} diff --git a/server/sonar-web/src/main/js/app/styles/sonar.css b/server/sonar-web/src/main/js/app/styles/sonar.css index 5b6284ebeed..9e5a247cdd1 100644 --- a/server/sonar-web/src/main/js/app/styles/sonar.css +++ b/server/sonar-web/src/main/js/app/styles/sonar.css @@ -34,7 +34,6 @@ @import './components/alerts.css'; @import './components/issues.css'; @import './components/search-navigator.css'; -@import './components/tooltips.css'; @import './components/dropdowns.css'; @import './components/menu.css'; @import './components/page.css'; diff --git a/server/sonar-web/src/main/js/apps/account/projects/ProjectCard.tsx b/server/sonar-web/src/main/js/apps/account/projects/ProjectCard.tsx index cfa10ff8e37..15d180785b7 100644 --- a/server/sonar-web/src/main/js/apps/account/projects/ProjectCard.tsx +++ b/server/sonar-web/src/main/js/apps/account/projects/ProjectCard.tsx @@ -39,17 +39,15 @@ export default function ProjectCard({ project }: Props) {