From 7732de75eeea0f549bb65378f33a05d2aa1a38db Mon Sep 17 00:00:00 2001 From: =?utf8?q?C=C3=B4me=20Chilliet?= Date: Mon, 7 Aug 2023 11:32:27 +0200 Subject: [PATCH] Removed GroupCreatedEvent/GroupDeletedEvent from UpdateGroupsService MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This should be handled when mapping groups, not when registering their members. An empty group may still exist. Signed-off-by: Côme Chilliet --- apps/user_ldap/lib/Service/UpdateGroupsService.php | 6 ------ 1 file changed, 6 deletions(-) diff --git a/apps/user_ldap/lib/Service/UpdateGroupsService.php b/apps/user_ldap/lib/Service/UpdateGroupsService.php index ea707c7c9d8..faee092a372 100644 --- a/apps/user_ldap/lib/Service/UpdateGroupsService.php +++ b/apps/user_ldap/lib/Service/UpdateGroupsService.php @@ -38,7 +38,6 @@ use OCA\User_LDAP\Db\GroupMembershipMapper; use OCA\User_LDAP\Group_Proxy; use OCP\DB\Exception; use OCP\EventDispatcher\IEventDispatcher; -use OCP\Group\Events\GroupCreatedEvent; use OCP\Group\Events\UserAddedEvent; use OCP\Group\Events\UserRemovedEvent; use OCP\IGroup; @@ -151,9 +150,6 @@ class UpdateGroupsService { $users = $this->groupBackend->usersInGroup($createdGroup); $groupObject = $this->groupManager->get($createdGroup); - if ($groupObject instanceof IGroup) { - $this->dispatcher->dispatchTyped(new GroupCreatedEvent($groupObject)); - } foreach ($users as $user) { $this->groupMembershipMapper->insert(GroupMembership::fromParams(['groupid' => $createdGroup,'userid' => $user])); if ($groupObject instanceof IGroup) { @@ -188,8 +184,6 @@ class UpdateGroupsService { } } - //TODO find a way to dispatch GroupDeletedEvent - $this->logger->info( 'service "updateGroups" – groups {removedGroups} were removed.', [ -- 2.39.5