From 780a21c42105fe532f54f841a3d8369eb3303eaf Mon Sep 17 00:00:00 2001 From: John Alhroos Date: Fri, 29 Oct 2010 08:36:02 +0000 Subject: [PATCH] Fixes style attributes remaining in DOM when swapping reverse positioning in SplitPanel. svn changeset:15774/svn branch:6.5 --- src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java | 10 ++++++---- src/com/vaadin/ui/SplitPanel.java | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java b/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java index 28feb6c1db..37546eea07 100644 --- a/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java +++ b/src/com/vaadin/terminal/gwt/client/ui/VSplitPanel.java @@ -217,9 +217,7 @@ public class VSplitPanel extends ComplexPanel implements Container, setLocked(uidl.getBooleanAttribute("locked")); - if (uidl.hasAttribute("reversed")) { - setPositionReversed(uidl.getBooleanAttribute("reversed")); - } + setPositionReversed(uidl.getBooleanAttribute("reversed")); setStylenames(); @@ -273,7 +271,11 @@ public class VSplitPanel extends ComplexPanel implements Container, } private void setPositionReversed(boolean reversed) { - positionReversed = reversed; + if (positionReversed != reversed) { + DOM.setStyleAttribute(splitter, "right", ""); + DOM.setStyleAttribute(splitter, "left", ""); + positionReversed = reversed; + } } private void setSplitPosition(String pos) { diff --git a/src/com/vaadin/ui/SplitPanel.java b/src/com/vaadin/ui/SplitPanel.java index cfa391f010..704b04c94c 100644 --- a/src/com/vaadin/ui/SplitPanel.java +++ b/src/com/vaadin/ui/SplitPanel.java @@ -470,7 +470,7 @@ public class SplitPanel extends AbstractLayout { if (variables.containsKey("position") && !isLocked()) { Integer newPos = (Integer) variables.get("position"); - setSplitPosition(newPos, posUnit, false); + setSplitPosition(newPos, posUnit, posReversed); } if (variables.containsKey(SPLITTER_CLICK_EVENT)) { -- 2.39.5