From 7b926116e20842568e0f1a6c3e67bb2f742cf6fa Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Sun, 6 Dec 2020 01:42:56 +0000 Subject: [PATCH] Update RuboCop Performance to 1.9 (#34159). git-svn-id: http://svn.redmine.org/redmine/trunk@20582 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 21 +++++++++++++++++++++ Gemfile | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a536c9609..c2de6bab6 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -500,6 +500,19 @@ Performance/AncestorsInclude: - 'test/unit/issue_priority_test.rb' - 'test/unit/time_entry_activity_test.rb' +# Cop supports --auto-correct. +Performance/BlockGivenWithExplicitBlock: + Exclude: + - 'app/controllers/account_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/helpers/application_helper.rb' + - 'app/models/mailer.rb' + - 'app/models/user.rb' + - 'lib/redmine/scm/adapters/abstract_adapter.rb' + - 'lib/redmine/views/builders.rb' + - 'lib/redmine/views/builders/structure.rb' + - 'lib/redmine/wiki_formatting/macros.rb' + # Configuration parameters: MinSize. Performance/CollectionLiteralInLoop: Exclude: @@ -521,6 +534,14 @@ Performance/CollectionLiteralInLoop: - 'test/unit/repository_git_test.rb' - 'test/unit/repository_mercurial_test.rb' +# Cop supports --auto-correct. +Performance/ConstantRegexp: + Exclude: + - 'app/models/changeset.rb' + - 'lib/redmine/scm/adapters/cvs_adapter.rb' + - 'lib/redmine/wiki_formatting/textile/formatter.rb' + - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' + Performance/FixedSize: Exclude: - 'test/integration/api_test/issues_test.rb' diff --git a/Gemfile b/Gemfile index 89c8a8f53..6d27985e7 100644 --- a/Gemfile +++ b/Gemfile @@ -93,7 +93,7 @@ group :test do gem "selenium-webdriver" # RuboCop gem 'rubocop', '~> 1.5.2' - gem 'rubocop-performance', '~> 1.8.0' + gem 'rubocop-performance', '~> 1.9.0' gem 'rubocop-rails', '~> 2.8.0' end -- 2.39.5