From 7c80efae717e0f63350829250e2183e0b44e6645 Mon Sep 17 00:00:00 2001 From: Marius Balteanu Date: Mon, 28 Nov 2022 22:41:53 +0000 Subject: [PATCH] Query display types should accept only known types (#37925). Patch by Alexander Meindl. git-svn-id: https://svn.redmine.org/redmine/trunk@21965 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/query.rb | 2 +- test/unit/query_test.rb | 14 ++++++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/app/models/query.rb b/app/models/query.rb index e18b06805..3313248c4 100644 --- a/app/models/query.rb +++ b/app/models/query.rb @@ -1065,7 +1065,7 @@ class Query < ActiveRecord::Base end def display_type=(type) - unless type || self.available_display_types.include?(type) + unless type && self.available_display_types.include?(type) type = self.available_display_types.first end options[:display_type] = type diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb index 1591e985e..e4ac5bd6f 100644 --- a/test/unit/query_test.rb +++ b/test/unit/query_test.rb @@ -2880,4 +2880,18 @@ class QueryTest < ActiveSupport::TestCase assert_equal 1, query.issue_count end + + def test_display_type_should_accept_known_types + query = ProjectQuery.new(:name => '_') + query.display_type = 'list' + + assert_equal 'list', query.display_type + end + + def test_display_type_should_not_accept_unknown_types + query = ProjectQuery.new(:name => '_') + query.display_type = 'invalid' + + assert_equal 'board', query.display_type + end end -- 2.39.5