From 7e53bc4c96453b744ebe478d912378c989ea7a78 Mon Sep 17 00:00:00 2001 From: Wouter Admiraal Date: Thu, 25 Aug 2022 13:29:57 +0200 Subject: [PATCH] SONAR-16710 [892974] Link or button text lacks 4.5:1 contrast ratio on hover or focus --- .../src/main/js/app/components/nav/component/Menu.css | 10 +++------- .../src/main/js/app/components/nav/component/Menu.tsx | 2 +- .../sonar-web/src/main/js/components/ui/NavBarTabs.css | 8 ++++---- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/server/sonar-web/src/main/js/app/components/nav/component/Menu.css b/server/sonar-web/src/main/js/app/components/nav/component/Menu.css index 2602439afa4..cb73d4e7fb8 100644 --- a/server/sonar-web/src/main/js/app/components/nav/component/Menu.css +++ b/server/sonar-web/src/main/js/app/components/nav/component/Menu.css @@ -17,13 +17,9 @@ * along with this program; if not, write to the Free Software Foundation, * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ -.navbar-tabs > li > .menu-button { - color: var(--darkBlue) !important; -} - -.navbar-tabs > li > .menu-button:hover { - color: var(--blue) !important; - border-bottom-color: transparent !important; +.navbar-tabs > li > .show-project-info-button { + color: var(--primary) !important; + border-bottom-width: 1px; } .navbar-tabs > li > .disabled-link, diff --git a/server/sonar-web/src/main/js/app/components/nav/component/Menu.tsx b/server/sonar-web/src/main/js/app/components/nav/component/Menu.tsx index a01609d78a8..7c76a14f810 100644 --- a/server/sonar-web/src/main/js/app/components/nav/component/Menu.tsx +++ b/server/sonar-web/src/main/js/app/components/nav/component/Menu.tsx @@ -360,7 +360,7 @@ export class Menu extends React.PureComponent { (isProject || isApplication) && (
  • { this.projectInfoLink = node; diff --git a/server/sonar-web/src/main/js/components/ui/NavBarTabs.css b/server/sonar-web/src/main/js/components/ui/NavBarTabs.css index 91e00f53a16..c6d8d2617d5 100644 --- a/server/sonar-web/src/main/js/components/ui/NavBarTabs.css +++ b/server/sonar-web/src/main/js/components/ui/NavBarTabs.css @@ -30,7 +30,7 @@ } .navbar-tabs > li > a, -.navbar-tabs > li > button.button-link { +.navbar-tabs > li > .button-link { display: block; height: var(--controlHeight); line-height: 16px; @@ -44,8 +44,8 @@ .navbar-tabs > li > a.active, .navbar-tabs > li > a:hover, .navbar-tabs > li > a:focus, -.navbar-tabs > li > button.button-link.active, -.navbar-tabs > li > button.button-link:hover, -.navbar-tabs > li > button.button-link:focus { +.navbar-tabs > li > .button-link.active, +.navbar-tabs > li > .button-link:hover, +.navbar-tabs > li > .button-link:focus { border-bottom-color: var(--blue); } -- 2.39.5