From 7f52b2e8221f58586b5c66dfa11b2bc2a79af204 Mon Sep 17 00:00:00 2001 From: Fabian Lange Date: Sun, 14 Jul 2013 16:38:26 +0200 Subject: [PATCH] Improved AbstractClientConnector performance (#12219) Avoiding duplicate lookup of connector hierarchy when a component shall be marked dirty. Optimized if statement to fail fast. Change-Id: I3ac82d64b235ebfd1888a6076c595f351018d887 --- server/src/com/vaadin/server/AbstractClientConnector.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/src/com/vaadin/server/AbstractClientConnector.java b/server/src/com/vaadin/server/AbstractClientConnector.java index c3101924dd..91a9e41522 100644 --- a/server/src/com/vaadin/server/AbstractClientConnector.java +++ b/server/src/com/vaadin/server/AbstractClientConnector.java @@ -224,9 +224,9 @@ public abstract class AbstractClientConnector implements ClientConnector, } if (markAsDirty) { UI ui = getUI(); - if (ui != null && !ui.getConnectorTracker().isWritingResponse() - && !ui.getConnectorTracker().isDirty(this)) { - markAsDirty(); + if (ui != null && !ui.getConnectorTracker().isDirty(this) + && !ui.getConnectorTracker().isWritingResponse()) { + ui.getConnectorTracker().markDirty(this); } } return sharedState; -- 2.39.5