From 81655230ae4cc96b67ffc697bfd1da09e72ed67c Mon Sep 17 00:00:00 2001 From: Eric Barboni Date: Tue, 14 Oct 2014 21:30:11 +0200 Subject: [PATCH] sonar fixes --- .../java/org/apache/archiva/checksum/ChecksumAlgorithm.java | 6 +++--- .../java/org/apache/archiva/checksum/ChecksummedFile.java | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/archiva-modules/archiva-base/archiva-checksum/src/main/java/org/apache/archiva/checksum/ChecksumAlgorithm.java b/archiva-modules/archiva-base/archiva-checksum/src/main/java/org/apache/archiva/checksum/ChecksumAlgorithm.java index 18e7ec023..71f051f72 100644 --- a/archiva-modules/archiva-base/archiva-checksum/src/main/java/org/apache/archiva/checksum/ChecksumAlgorithm.java +++ b/archiva-modules/archiva-base/archiva-checksum/src/main/java/org/apache/archiva/checksum/ChecksumAlgorithm.java @@ -50,17 +50,17 @@ public enum ChecksumAlgorithm { /** * The MessageDigest algorithm for this hash. */ - private String algorithm; + private final String algorithm; /** * The file extension for this ChecksumAlgorithm. */ - private String ext; + private final String ext; /** * The checksum type, the key that you see in checksum files. */ - private String type; + private final String type; /** * Construct a ChecksumAlgorithm diff --git a/archiva-modules/archiva-base/archiva-checksum/src/main/java/org/apache/archiva/checksum/ChecksummedFile.java b/archiva-modules/archiva-base/archiva-checksum/src/main/java/org/apache/archiva/checksum/ChecksummedFile.java index 89181b5fd..366e16e0a 100644 --- a/archiva-modules/archiva-base/archiva-checksum/src/main/java/org/apache/archiva/checksum/ChecksummedFile.java +++ b/archiva-modules/archiva-base/archiva-checksum/src/main/java/org/apache/archiva/checksum/ChecksummedFile.java @@ -25,7 +25,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.io.File; -import java.io.FileInputStream; import java.io.IOException; import java.io.InputStream; import java.nio.file.Files; @@ -52,7 +51,7 @@ import java.util.regex.Pattern; */ public class ChecksummedFile { - private Logger log = LoggerFactory.getLogger( ChecksummedFile.class ); + private final Logger log = LoggerFactory.getLogger( ChecksummedFile.class ); private final File referenceFile; -- 2.39.5