From 8198d218935f649ada4f1e9dbc2e7bfe377a1388 Mon Sep 17 00:00:00 2001 From: James Moger Date: Thu, 20 Jun 2013 17:26:03 -0400 Subject: [PATCH] Set rel="nofollow" on compressed download links --- releases.moxie | 11 ++++++----- .../wicket/panels/CompressedDownloadsPanel.java | 3 ++- .../java/com/gitblit/wicket/panels/LinkPanel.java | 6 ++++++ 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/releases.moxie b/releases.moxie index 4d2e8752..74e7d14d 100644 --- a/releases.moxie +++ b/releases.moxie @@ -41,6 +41,7 @@ r17: { - Properly set application/json content-type on api calls - Make days back filter choices a setting - Changed default days back filter setting to 7 days + - Set rel="nofollow" on compressed download links - Improved page title - Updated Polish translation - Updated Japanese translation @@ -71,7 +72,7 @@ r17: { contributors: - Bandarupalli Satyanarayana - - Chad H. + - Chad Horohoe - Christian Aistleitner - David Ostrovsky - Egbert Teeselink @@ -86,7 +87,7 @@ r17: { - Lukasz Jader - Martijn Laan - Matthias Bauer - - Micha�l Pailloncy + - Michael Pailloncy - Michael Schaefers - Oliver Doepner - Philip Boutros @@ -99,14 +100,14 @@ r17: { - Thomas Pummer - William Whittle - Yukihiko Sawanobori - - github/akquinet - - github/dapengme + - github/akquinet + - github/dapengme dependencyChanges: - JGit 3.0.0-SNAPSHOT - Iconic font - AngularJS 1.0.7 - - FreeMarker 2.3.19 + - FreeMarker 2.3.19 settings: - { name: 'git.daemonBindInterface', defaultValue: 'localhost' } diff --git a/src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java b/src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java index b22c7587..122ae55e 100644 --- a/src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java +++ b/src/main/java/com/gitblit/wicket/panels/CompressedDownloadsPanel.java @@ -60,7 +60,8 @@ public class CompressedDownloadsPanel extends Panel { String href = DownloadZipServlet.asLink(baseUrl, repositoryName, objectId, path, format); - Component c = new LinkPanel("compressedLink", null, format.name(), href); + LinkPanel c = new LinkPanel("compressedLink", null, format.name(), href); + c.setNoFollow(); item.add(c); Label lb = new Label("linkSep", "|"); lb.setVisible(counter > 0); diff --git a/src/main/java/com/gitblit/wicket/panels/LinkPanel.java b/src/main/java/com/gitblit/wicket/panels/LinkPanel.java index 688a9576..21470b27 100644 --- a/src/main/java/com/gitblit/wicket/panels/LinkPanel.java +++ b/src/main/java/com/gitblit/wicket/panels/LinkPanel.java @@ -15,6 +15,7 @@ */ package com.gitblit.wicket.panels; +import org.apache.wicket.Component; import org.apache.wicket.PageParameters; import org.apache.wicket.behavior.SimpleAttributeModifier; import org.apache.wicket.markup.html.WebPage; @@ -106,5 +107,10 @@ public class LinkPanel extends Panel { link.add(new Label("label", labelModel)); add(link); } + + public void setNoFollow() { + Component c = get("link"); + c.add(new SimpleAttributeModifier("rel", "nofollow")); + } } -- 2.39.5