From 81d6e63471746864fea2d05bb15186c0ad37dbfd Mon Sep 17 00:00:00 2001 From: David Gageot Date: Tue, 17 Jul 2012 15:11:47 +0200 Subject: [PATCH] SONAR-3665 Boolean widget properties are not saved when editing a widget --- .../src/main/webapp/WEB-INF/app/helpers/properties_helper.rb | 2 +- .../main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sonar-server/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb b/sonar-server/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb index 65fb7cc3ebd..9e4eb3e29ae 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb +++ b/sonar-server/src/main/webapp/WEB-INF/app/helpers/properties_helper.rb @@ -30,7 +30,7 @@ module PropertiesHelper password_field_tag key, value, {:size => 25}.update(options) elsif type==PropertyType::TYPE_BOOLEAN - check_box_tag key, "true", value=='true', options + (hidden_field_tag key, 'false', options) + (check_box_tag key, 'true', value=='true', options) elsif type==PropertyType::TYPE_INTEGER text_field_tag key, value, {:size => 10}.update(options) diff --git a/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb b/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb index d19fe776114..9ac91abcbac 100644 --- a/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb +++ b/sonar-server/src/main/webapp/WEB-INF/app/helpers/widget_properties_helper.rb @@ -21,7 +21,7 @@ module WidgetPropertiesHelper include PropertiesHelper def property_value_field(definition, value) - property_value definition.key(), definition.type.name(), value || definition.defaultValue() + property_value definition.key(), definition.type.name(), value.nil? ? definition.defaultValue() : value end def resource_value_field(value) -- 2.39.5