From 81ef038587ae640c2aec351ce3046352d3326da4 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Tue, 25 Oct 2011 06:10:12 +0000 Subject: [PATCH] scm: mercurial: drop supporting below Mercurial 1.1 (#9465) On November 1st 2011, Mercurial 2.0 will be released. On Mercurial 1.1.2, unit lib test fails with following error.
Traceback (most recent call last):
  File "/WEB-DOWN/hg-repo/hg-crew/hg", line 20, in 
    mercurial.dispatch.run()
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 20, in run
    sys.exit(dispatch(sys.argv[1:]))
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 29, in dispatch
    return _runcatch(u, args)
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 45, in _runcatch
    return _dispatch(ui, args)
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 367, in _dispatch
    ret = _runcommand(ui, options, cmd, d)
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 416, in _runcommand
    return checkargs()
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 376, in checkargs
    return cmdfunc()
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/dispatch.py", line 361, in 
    d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
  File "/WEB-DOWN/hg-repo/hg-crew/mercurial/util.py", line 715, in check
    return func(*args, **kwargs)
  File "/REDMINE-1/hg-workdir/redmine-bb-all/lib/redmine/scm/adapters/mercurial/redminehelper.py", line 149, in rhlog
    if hg.util.version() >= '1.6':
AttributeError: 'module' object has no attribute 'version'

  1) Error:
test_nodes_in_branch(MercurialAdapterTest):
Redmine::Scm::Adapters::MercurialAdapter::HgCommandAborted: hg exited with non-zero status: 1
    lib/redmine/scm/adapters/mercurial_adapter.rb:306:in `hg'
    lib/redmine/scm/adapters/mercurial_adapter.rb:234:in `nodes_in_branch'
    test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb:311:in `test_nodes_in_branch'
    test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb:304:in `each'
    test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb:304:in `test_nodes_in_branch'
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@7650 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .../scm/adapters/mercurial/hg-template-0.9.5.tmpl | 12 ------------ lib/redmine/scm/adapters/mercurial_adapter.rb | 9 ++------- .../redmine/scm/adapters/mercurial_adapter_test.rb | 10 ++++++---- 3 files changed, 8 insertions(+), 23 deletions(-) delete mode 100644 lib/redmine/scm/adapters/mercurial/hg-template-0.9.5.tmpl diff --git a/lib/redmine/scm/adapters/mercurial/hg-template-0.9.5.tmpl b/lib/redmine/scm/adapters/mercurial/hg-template-0.9.5.tmpl deleted file mode 100644 index 3cf584aed..000000000 --- a/lib/redmine/scm/adapters/mercurial/hg-template-0.9.5.tmpl +++ /dev/null @@ -1,12 +0,0 @@ -changeset = 'This template must be used with --debug option\n' -changeset_quiet = 'This template must be used with --debug option\n' -changeset_verbose = 'This template must be used with --debug option\n' -changeset_debug = '\n{author|escape}\n{date|isodate}\n\n{files}{file_adds}{file_dels}{file_copies}\n{desc|escape}\n{tags}\n\n' - -file = '{file|urlescape}\n' -file_add = '{file_add|urlescape}\n' -file_del = '{file_del|urlescape}\n' -file_copy = '{name|urlescape}\n' -tag = '{tag|escape}\n' -header='\n\n\n' -# footer="" \ No newline at end of file diff --git a/lib/redmine/scm/adapters/mercurial_adapter.rb b/lib/redmine/scm/adapters/mercurial_adapter.rb index 3d8ef617a..53f24735c 100644 --- a/lib/redmine/scm/adapters/mercurial_adapter.rb +++ b/lib/redmine/scm/adapters/mercurial_adapter.rb @@ -47,7 +47,7 @@ module Redmine end def client_available - client_version_above?([0, 9, 5]) + client_version_above?([1, 2]) end def hgversion @@ -72,12 +72,7 @@ module Redmine end def template_path_for(version) - if ((version <=> [0,9,5]) > 0) || version.empty? - ver = "1.0" - else - ver = "0.9.5" - end - "#{HELPERS_DIR}/#{TEMPLATE_NAME}-#{ver}.#{TEMPLATE_EXTENSION}" + "#{HELPERS_DIR}/#{TEMPLATE_NAME}-1.0.#{TEMPLATE_EXTENSION}" end end diff --git a/test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb b/test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb index 4c946ba22..10a78c4af 100644 --- a/test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb +++ b/test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb @@ -53,12 +53,14 @@ begin end def test_template_path - to_test = { [0,9,5] => "0.9.5", - [1,0] => "1.0", + to_test = { + [1,2] => "1.0", [] => "1.0", - [1,0,1] => "1.0", + [1,2,1] => "1.0", [1,7] => "1.0", - [1,7,1] => "1.0" } + [1,7,1] => "1.0", + [2,0] => "1.0", + } to_test.each do |v, template| test_template_path_for(v, template) end -- 2.39.5