From 844e190ce9de81aa24d82269be5130a14e1cf5b1 Mon Sep 17 00:00:00 2001
From: Zipeng WU <zipeng.wu@sonarsource.com>
Date: Mon, 15 Feb 2021 09:01:33 +0100
Subject: [PATCH] Fix critical code smell

---
 .../PRDecorationBinding.tsx                   | 22 ++++++-------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/settings/components/pullRequestDecorationBinding/PRDecorationBinding.tsx b/server/sonar-web/src/main/js/apps/settings/components/pullRequestDecorationBinding/PRDecorationBinding.tsx
index c38e99da161..c00b8403d59 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/pullRequestDecorationBinding/PRDecorationBinding.tsx
+++ b/server/sonar-web/src/main/js/apps/settings/components/pullRequestDecorationBinding/PRDecorationBinding.tsx
@@ -169,9 +169,13 @@ export class PRDecorationBinding extends React.PureComponent<Props & StateProps,
     const slug = almSpecificFields?.slug;
     const monorepo = almSpecificFields?.monorepo ?? false;
 
+    if (!repository) {
+      return Promise.reject();
+    }
+
     switch (alm) {
       case AlmKeys.Azure: {
-        if (!slug || !repository) {
+        if (!slug) {
           return Promise.reject();
         }
         return setProjectAzureBinding({
@@ -183,7 +187,7 @@ export class PRDecorationBinding extends React.PureComponent<Props & StateProps,
         });
       }
       case AlmKeys.BitbucketServer: {
-        if (!repository || !slug) {
+        if (!slug) {
           return Promise.reject();
         }
         return setProjectBitbucketBinding({
@@ -195,9 +199,6 @@ export class PRDecorationBinding extends React.PureComponent<Props & StateProps,
         });
       }
       case AlmKeys.BitbucketCloud: {
-        if (!repository) {
-          return Promise.reject();
-        }
         return setProjectBitbucketCloudBinding({
           almSetting,
           project,
@@ -206,13 +207,7 @@ export class PRDecorationBinding extends React.PureComponent<Props & StateProps,
       }
       case AlmKeys.GitHub: {
         // By default it must remain true.
-        const summaryCommentEnabled =
-          almSpecificFields?.summaryCommentEnabled === undefined
-            ? true
-            : almSpecificFields?.summaryCommentEnabled;
-        if (!repository) {
-          return Promise.reject();
-        }
+        const summaryCommentEnabled = almSpecificFields?.summaryCommentEnabled ?? true;
         return setProjectGithubBinding({
           almSetting,
           project,
@@ -223,9 +218,6 @@ export class PRDecorationBinding extends React.PureComponent<Props & StateProps,
       }
 
       case AlmKeys.GitLab: {
-        if (!repository) {
-          return Promise.reject();
-        }
         return setProjectGitlabBinding({
           almSetting,
           project,
-- 
2.39.5