From 849c6fd5376e12c6093c557bd4836ef0b145f145 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Scott=20Gonz=C3=A1lez?= Date: Wed, 20 Aug 2014 16:04:54 -0400 Subject: [PATCH] Accordion: Avoid memory leak during refresh Ref #10056 Closes gh-1319 --- ui/accordion.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ui/accordion.js b/ui/accordion.js index 5b748a3f2..946437197 100644 --- a/ui/accordion.js +++ b/ui/accordion.js @@ -259,13 +259,22 @@ return $.widget( "ui.accordion", { }, _processPanels: function() { + var prevHeaders = this.headers, + prevPanels = this.panels; + this.headers = this.element.find( this.options.header ) .addClass( "ui-accordion-header ui-state-default ui-corner-all" ); - this.headers.next() + this.panels = this.headers.next() .addClass( "ui-accordion-content ui-helper-reset ui-widget-content ui-corner-bottom" ) .filter( ":not(.ui-accordion-content-active)" ) .hide(); + + // Avoid memory leaks (#10056) + if ( prevPanels ) { + this._off( prevHeaders.not( this.headers ) ); + this._off( prevPanels.not( this.panels ) ); + } }, _refresh: function() { -- 2.39.5