From 867ec5b07cb34a03f402029cc88ad09cfdd37b34 Mon Sep 17 00:00:00 2001
From: Brett Porter <brett@apache.org>
Date: Thu, 13 Jul 2006 05:20:41 +0000
Subject: [PATCH] better handling of index not existing

git-svn-id: https://svn.apache.org/repos/asf/maven/repository-manager/trunk@421500 13f79535-47bb-0310-9956-ffa450edef68
---
 .../repository/indexing/AbstractRepositoryIndex.java      | 2 +-
 .../repository/manager/web/action/QuickSearchAction.java  | 8 ++++++--
 maven-repository-webapp/src/main/resources/xwork.xml      | 1 +
 .../src/main/webapp/WEB-INF/jsp/quickSearch.jsp           | 1 +
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java
index 2b9af2822..27f13afe3 100644
--- a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java
+++ b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/AbstractRepositoryIndex.java
@@ -261,7 +261,7 @@ public abstract class AbstractRepositoryIndex
      * @return true if the index already exists
      * @throws RepositoryIndexException
      */
-    protected boolean indexExists()
+    public boolean indexExists()
         throws RepositoryIndexException
     {
         if ( IndexReader.indexExists( indexPath ) )
diff --git a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/QuickSearchAction.java b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/QuickSearchAction.java
index 35f5de74f..c480af4b6 100644
--- a/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/QuickSearchAction.java
+++ b/maven-repository-webapp/src/main/java/org/apache/maven/repository/manager/web/action/QuickSearchAction.java
@@ -83,8 +83,6 @@ public class QuickSearchAction
     {
         // TODO: give action message if indexing is in progress
 
-        // TODO: return zero results if index doesn't yet exist
-
         assert q != null && q.length() != 0;
 
         Configuration configuration = configurationStore.getConfigurationFromStore();
@@ -94,6 +92,12 @@ public class QuickSearchAction
 
         ArtifactRepositoryIndex index = factory.createArtifactRepositoryIndex( indexPath, repository );
 
+        if ( !index.indexExists() )
+        {
+            addActionError( "The repository is not yet indexed. Please wait, and then try again." );
+            return ERROR;
+        }
+
         searchResult = searchLayer.searchGeneral( q, index );
 
         return SUCCESS;
diff --git a/maven-repository-webapp/src/main/resources/xwork.xml b/maven-repository-webapp/src/main/resources/xwork.xml
index 9a4ccfd01..9a71a8c4c 100644
--- a/maven-repository-webapp/src/main/resources/xwork.xml
+++ b/maven-repository-webapp/src/main/resources/xwork.xml
@@ -48,6 +48,7 @@
     <action name="quickSearch" class="quickSearchAction">
       <result name="input">/WEB-INF/jsp/quickSearch.jsp</result>
       <result>/WEB-INF/jsp/results.jsp</result>
+      <result name="error">/WEB-INF/jsp/quickSearch.jsp</result>
     </action>
 
     <!-- TODO! old actions
diff --git a/maven-repository-webapp/src/main/webapp/WEB-INF/jsp/quickSearch.jsp b/maven-repository-webapp/src/main/webapp/WEB-INF/jsp/quickSearch.jsp
index 6b800b9da..aacb872a8 100644
--- a/maven-repository-webapp/src/main/webapp/WEB-INF/jsp/quickSearch.jsp
+++ b/maven-repository-webapp/src/main/webapp/WEB-INF/jsp/quickSearch.jsp
@@ -33,6 +33,7 @@
     </ww:form>
     <p>
       Enter your search terms. A variety of data will be searched for your keywords.
+      <ww:actionerror />
     </p>
   </div>
 </div>
-- 
2.39.5