From 86e6cb7edb28d01dd888db9d38ef7c14978d56d3 Mon Sep 17 00:00:00 2001 From: Vsevolod Stakhov Date: Tue, 21 Sep 2021 19:22:26 +0100 Subject: [PATCH] [Minor] Fix use after free Reported by: @citrin --- src/libserver/re_cache.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libserver/re_cache.c b/src/libserver/re_cache.c index 631981b30..4d631da01 100644 --- a/src/libserver/re_cache.c +++ b/src/libserver/re_cache.c @@ -2065,15 +2065,15 @@ rspamd_re_cache_compile_timer_cb (EV_P_ ev_timer *w, int revents ) g_free (hs_pats[j]); } + err = g_error_new (rspamd_re_cache_quark (), EINVAL, + "cannot create tree of regexp when processing '%s': %s", + hs_pats[hs_errors->expression], hs_errors->message); g_free (hs_pats); g_free (hs_exts); close (fd); unlink (path); hs_free_compile_error (hs_errors); - err = g_error_new (rspamd_re_cache_quark (), EINVAL, - "cannot create tree of regexp when processing '%s': %s", - hs_pats[hs_errors->expression], hs_errors->message); rspamd_re_cache_compile_err (EV_A_ w, err, cbdata); return; -- 2.39.5