From 87cfb23610eacd370452151210017c045adaa42d Mon Sep 17 00:00:00 2001 From: Stas Vilchik Date: Tue, 16 Feb 2016 16:23:18 +0100 Subject: [PATCH] SONAR-7191 Update the background tasks page to reflect latest WS changes --- ...filter_elements_on_project_level_page.html | 2 +- .../components/BackgroundTasksApp.js | 2 +- .../apps/background-tasks/components/Task.js | 28 ++---- .../background-tasks/components/search.js | 29 +++--- .../apps/background-tasks/components/tasks.js | 3 +- .../containers/BackgroundTasksAppContainer.js | 2 +- .../containers/SearchContainer.js | 3 +- .../containers/TasksContainer.js | 3 +- .../js/apps/background-tasks/store/actions.js | 15 ++- .../apps/background-tasks/store/reducers.js | 1 + .../tests/apps/background-tasks-test.js | 91 ++++++++----------- 11 files changed, 82 insertions(+), 97 deletions(-) diff --git a/it/it-tests/src/test/resources/projectAdministration/BackgroundTasksTest/should_not_display_failing_and_search_and_filter_elements_on_project_level_page.html b/it/it-tests/src/test/resources/projectAdministration/BackgroundTasksTest/should_not_display_failing_and_search_and_filter_elements_on_project_level_page.html index fee4c281aca..92e83f2859e 100644 --- a/it/it-tests/src/test/resources/projectAdministration/BackgroundTasksTest/should_not_display_failing_and_search_and_filter_elements_on_project_level_page.html +++ b/it/it-tests/src/test/resources/projectAdministration/BackgroundTasksTest/should_not_display_failing_and_search_and_filter_elements_on_project_level_page.html @@ -56,7 +56,7 @@ assertElementNotPresent - css=.search-box + css=.js-search diff --git a/server/sonar-web/src/main/js/apps/background-tasks/components/BackgroundTasksApp.js b/server/sonar-web/src/main/js/apps/background-tasks/components/BackgroundTasksApp.js index 9f2192ab629..3418548c36e 100644 --- a/server/sonar-web/src/main/js/apps/background-tasks/components/BackgroundTasksApp.js +++ b/server/sonar-web/src/main/js/apps/background-tasks/components/BackgroundTasksApp.js @@ -30,7 +30,7 @@ import ListFooterContainer from '../containers/ListFooterContainer'; export default class BackgroundTasksApp extends Component { componentDidMount () { - this.props.initApp(); + this.props.initApp(this.props.options.component); } getComponentFilter () { diff --git a/server/sonar-web/src/main/js/apps/background-tasks/components/Task.js b/server/sonar-web/src/main/js/apps/background-tasks/components/Task.js index 58daa47f6bb..c8bbf919a95 100644 --- a/server/sonar-web/src/main/js/apps/background-tasks/components/Task.js +++ b/server/sonar-web/src/main/js/apps/background-tasks/components/Task.js @@ -26,21 +26,9 @@ import TaskDate from './TaskDate'; import TaskExecutionTime from './TaskExecutionTime'; import TaskCancelButton from './TaskCancelButton'; import TaskLogsLink from './TaskLogsLink'; - import { STATUSES } from './../constants'; - -function renderFilter (task) { - // if (this.props.options && this.props.options.component) { - // return null; - // } - return - - ; -} - -export default function Task ({ task, index, tasks, onCancelTask, onFilterTask }) { +export default function Task ({ task, index, tasks, component, onCancelTask, onFilterTask }) { function handleFilterTask (task, e) { e.preventDefault(); onFilterTask(task); @@ -68,12 +56,14 @@ export default function Task ({ task, index, tasks, onCancelTask, onFilterTask } - + {!component && ( + + )} ); diff --git a/server/sonar-web/src/main/js/apps/background-tasks/components/search.js b/server/sonar-web/src/main/js/apps/background-tasks/components/search.js index 349b62ad9c3..507cae227ea 100644 --- a/server/sonar-web/src/main/js/apps/background-tasks/components/search.js +++ b/server/sonar-web/src/main/js/apps/background-tasks/components/search.js @@ -39,17 +39,23 @@ export default React.createClass({ }, renderSearchBox() { - if (this.props.options && this.props.options.component) { + if (this.props.component) { // do not render search form on the project-level page return null; } return ( - +
  • +
    + Component +
    + + +
  • ); }, @@ -97,12 +103,9 @@ export default React.createClass({ value={this.props.date} onChange={this.props.onDateChange}/> -
  • -
    - Component -
    - {this.renderSearchBox()} -
  • + + {this.renderSearchBox()} +