From 93632ed94f5ebbe0a3fb599bc6853c4a2f4f5c47 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Thu, 21 Jul 2022 02:52:22 +0000 Subject: [PATCH] Merged r21725 from trunk to 4.2-stable (#37450, #37476). git-svn-id: https://svn.redmine.org/redmine/branches/4.2-stable@21730 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/setting.rb | 2 +- test/unit/lib/redmine/plugin_test.rb | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/models/setting.rb b/app/models/setting.rb index 1418cf04b..45a12103e 100644 --- a/app/models/setting.rb +++ b/app/models/setting.rb @@ -105,7 +105,7 @@ class Setting < ActiveRecord::Base v = read_attribute(:value) # Unserialize serialized settings if available_settings[name]['serialized'] && v.is_a?(String) - v = YAML.safe_load(v, permitted_classes: [ActiveSupport::HashWithIndifferentAccess]) + v = YAML.safe_load(v, permitted_classes: [Symbol, ActiveSupport::HashWithIndifferentAccess]) v = force_utf8_strings(v) end v = v.to_sym if available_settings[name]['format'] == 'symbol' && !v.blank? diff --git a/test/unit/lib/redmine/plugin_test.rb b/test/unit/lib/redmine/plugin_test.rb index 92898e181..8e8cc3cdc 100644 --- a/test/unit/lib/redmine/plugin_test.rb +++ b/test/unit/lib/redmine/plugin_test.rb @@ -191,6 +191,13 @@ class Redmine::PluginTest < ActiveSupport::TestCase end end + def test_default_settings + @klass.register(:foo_plugin) {settings :default => {'key1' => 'abc', :key2 => 123}} + h = Setting.plugin_foo_plugin + assert_equal 'abc', h['key1'] + assert_equal 123, h[:key2] + end + def test_settings_warns_about_possible_partial_collision @klass.register(:foo_plugin) {settings :partial => 'foo/settings'} Rails.logger.expects(:warn) -- 2.39.5