From 94645ed75446ad4437eecf5aa342675fd0aa287b Mon Sep 17 00:00:00 2001
From: =?utf8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= <danxuliu@gmail.com>
Date: Thu, 22 Nov 2018 05:25:12 +0100
Subject: [PATCH] Add acceptance tests for marking a file as favorite in the
 details view
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
---
 tests/acceptance/features/app-files.feature   | 19 ++++++
 .../features/bootstrap/FilesAppContext.php    | 61 +++++++++++++++++++
 2 files changed, 80 insertions(+)

diff --git a/tests/acceptance/features/app-files.feature b/tests/acceptance/features/app-files.feature
index 33bed4a3ef2..c85cdc32b94 100644
--- a/tests/acceptance/features/app-files.feature
+++ b/tests/acceptance/features/app-files.feature
@@ -292,3 +292,22 @@ Feature: app-files
     When I unmark "welcome.txt" as favorite
     Then I see that "welcome.txt" is not marked as favorite
     And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list
+
+  Scenario: mark a file as favorite in the details view
+    Given I am logged in
+    And I open the details view for "welcome.txt"
+    And I see that the details view is open
+    When I mark the file as favorite in the details view
+    Then I see that "welcome.txt" is marked as favorite
+    And I see that the file is marked as favorite in the details view
+
+  Scenario: unmark a file as favorite in the details view
+    Given I am logged in
+    And I open the details view for "welcome.txt"
+    And I see that the details view is open
+    And I mark the file as favorite in the details view
+    And I see that "welcome.txt" is marked as favorite
+    And I see that the file is marked as favorite in the details view
+    When I unmark the file as favorite in the details view
+    Then I see that "welcome.txt" is not marked as favorite
+    And I see that the file is not marked as favorite in the details view
diff --git a/tests/acceptance/features/bootstrap/FilesAppContext.php b/tests/acceptance/features/bootstrap/FilesAppContext.php
index d9ac6431716..a5d2c636f3e 100644
--- a/tests/acceptance/features/bootstrap/FilesAppContext.php
+++ b/tests/acceptance/features/bootstrap/FilesAppContext.php
@@ -86,6 +86,33 @@ class FilesAppContext implements Context, ActorAwareInterface {
 				describedAs("File name in details view in Files app");
 	}
 
+	/**
+	 * @return Locator
+	 */
+	public static function favoriteActionInFileDetailsInDetailsView() {
+		return Locator::forThe()->css(".action-favorite")->
+				descendantOf(self::fileDetailsInDetailsView())->
+				describedAs("Favorite action in file details in details view in Files app");
+	}
+
+	/**
+	 * @return Locator
+	 */
+	public static function notFavoritedStateIconInFileDetailsInDetailsView() {
+		return Locator::forThe()->css(".icon-star")->
+				descendantOf(self::favoriteActionInFileDetailsInDetailsView())->
+				describedAs("Not favorited state icon in file details in details view in Files app");
+	}
+
+	/**
+	 * @return Locator
+	 */
+	public static function favoritedStateIconInFileDetailsInDetailsView() {
+		return Locator::forThe()->css(".icon-starred")->
+				descendantOf(self::favoriteActionInFileDetailsInDetailsView())->
+				describedAs("Favorited state icon in file details in details view in Files app");
+	}
+
 	/**
 	 * @return Locator
 	 */
@@ -372,6 +399,24 @@ class FilesAppContext implements Context, ActorAwareInterface {
 		$this->actor->getSharedNotebook()["shared link"] = $this->actor->find(self::copyLinkButton(), 2)->getWrappedElement()->getAttribute("data-clipboard-text");
 	}
 
+	/**
+	 * @When I mark the file as favorite in the details view
+	 */
+	public function iMarkTheFileAsFavoriteInTheDetailsView() {
+		$this->iSeeThatTheFileIsNotMarkedAsFavoriteInTheDetailsView();
+
+		$this->actor->find(self::favoriteActionInFileDetailsInDetailsView(), 10)->click();
+	}
+
+	/**
+	 * @When I unmark the file as favorite in the details view
+	 */
+	public function iUnmarkTheFileAsFavoriteInTheDetailsView() {
+		$this->iSeeThatTheFileIsMarkedAsFavoriteInTheDetailsView();
+
+		$this->actor->find(self::favoriteActionInFileDetailsInDetailsView(), 10)->click();
+	}
+
 	/**
 	 * @When I check the tag :tag in the dropdown for tags in the details view
 	 */
@@ -500,6 +545,22 @@ class FilesAppContext implements Context, ActorAwareInterface {
 				$this->actor->find(self::fileNameInDetailsView(), 10)->getText(), $fileName);
 	}
 
+	/**
+	 * @Then I see that the file is marked as favorite in the details view
+	 */
+	public function iSeeThatTheFileIsMarkedAsFavoriteInTheDetailsView() {
+		PHPUnit_Framework_Assert::assertNotNull(
+				$this->actor->find(self::favoritedStateIconInFileDetailsInDetailsView(), 10));
+	}
+
+	/**
+	 * @Then I see that the file is not marked as favorite in the details view
+	 */
+	public function iSeeThatTheFileIsNotMarkedAsFavoriteInTheDetailsView() {
+		PHPUnit_Framework_Assert::assertNotNull(
+				$this->actor->find(self::notFavoritedStateIconInFileDetailsInDetailsView(), 10));
+	}
+
 	/**
 	 * @Then I see that the input field for tags in the details view is shown
 	 */
-- 
2.39.5