From 94ba9574cd5589bbf7a3671533390b43936fe65b Mon Sep 17 00:00:00 2001 From: Chris Aniszczyk Date: Wed, 18 Aug 2010 21:12:15 -0500 Subject: [PATCH] Allow for optional tagger and message in Tag We should be more lenient when tagging without an tagger or message. Currently, we will throw an NPE which is incorrect behavior. Change-Id: I04e30ce25a9432e4ca56c3f29658ecb24fb18d24 Signed-off-by: Chris Aniszczyk --- .../src/org/eclipse/jgit/lib/ObjectInserter.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectInserter.java b/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectInserter.java index 3d700ac49e..a9522452b6 100644 --- a/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectInserter.java +++ b/org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectInserter.java @@ -378,12 +378,15 @@ public abstract class ObjectInserter { w.write(tag.getTag()); w.write("\n"); - w.write("tagger "); - w.write(tag.getTagger().toExternalString()); - w.write('\n'); + if (tag.getTagger() != null) { + w.write("tagger "); + w.write(tag.getTagger().toExternalString()); + w.write('\n'); + } w.write('\n'); - w.write(tag.getMessage()); + if (tag.getMessage() != null) + w.write(tag.getMessage()); w.close(); } catch (IOException err) { // This should never occur, the only way to get it above is -- 2.39.5