From 97e33c2bd4a00e9222a687c563047103eaa718f3 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Wed, 4 Jan 2023 16:17:43 +0100 Subject: [PATCH] Fix unit tests of the ActionProviderStore Signed-off-by: Joas Schilling --- .../ContactsMenu/ActionProviderStoreTest.php | 31 ++++++++++++------- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/tests/lib/Contacts/ContactsMenu/ActionProviderStoreTest.php b/tests/lib/Contacts/ContactsMenu/ActionProviderStoreTest.php index 67f84042996..2543746ddb5 100644 --- a/tests/lib/Contacts/ContactsMenu/ActionProviderStoreTest.php +++ b/tests/lib/Contacts/ContactsMenu/ActionProviderStoreTest.php @@ -27,6 +27,7 @@ namespace Tests\Contacts\ContactsMenu; use OC\App\AppManager; use OC\Contacts\ContactsMenu\ActionProviderStore; use OC\Contacts\ContactsMenu\Providers\EMailProvider; +use OC\Contacts\ContactsMenu\Providers\LocalTimeProvider; use OC\Contacts\ContactsMenu\Providers\ProfileProvider; use OCP\App\IAppManager; use OCP\AppFramework\QueryException; @@ -60,8 +61,9 @@ class ActionProviderStoreTest extends TestCase { public function testGetProviders() { $user = $this->createMock(IUser::class); $provider1 = $this->createMock(ProfileProvider::class); - $provider2 = $this->createMock(EMailProvider::class); - $provider3 = $this->createMock(IProvider::class); + $provider2 = $this->createMock(LocalTimeProvider::class); + $provider3 = $this->createMock(EMailProvider::class); + $provider4 = $this->createMock(IProvider::class); $this->appManager->expects($this->once()) ->method('getEnabledAppsForUser') @@ -75,25 +77,28 @@ class ActionProviderStoreTest extends TestCase { 'OCA\Contacts\Provider1', ], ]); - $this->serverContainer->expects($this->exactly(3)) + $this->serverContainer->expects($this->exactly(4)) ->method('get') ->willReturnMap([ [ProfileProvider::class, $provider1], - [EMailProvider::class, $provider2], - ['OCA\Contacts\Provider1', $provider3] + [LocalTimeProvider::class, $provider2], + [EMailProvider::class, $provider3], + ['OCA\Contacts\Provider1', $provider4] ]); $providers = $this->actionProviderStore->getProviders($user); - $this->assertCount(3, $providers); + $this->assertCount(4, $providers); $this->assertInstanceOf(ProfileProvider::class, $providers[0]); - $this->assertInstanceOf(EMailProvider::class, $providers[1]); + $this->assertInstanceOf(LocalTimeProvider::class, $providers[1]); + $this->assertInstanceOf(EMailProvider::class, $providers[2]); } public function testGetProvidersOfAppWithIncompleInfo() { $user = $this->createMock(IUser::class); $provider1 = $this->createMock(ProfileProvider::class); - $provider2 = $this->createMock(EMailProvider::class); + $provider2 = $this->createMock(LocalTimeProvider::class); + $provider3 = $this->createMock(EMailProvider::class); $this->appManager->expects($this->once()) ->method('getEnabledAppsForUser') @@ -103,18 +108,20 @@ class ActionProviderStoreTest extends TestCase { ->method('getAppInfo') ->with('contacts') ->willReturn([/* Empty info.xml */]); - $this->serverContainer->expects($this->exactly(2)) + $this->serverContainer->expects($this->exactly(3)) ->method('get') ->willReturnMap([ [ProfileProvider::class, $provider1], - [EMailProvider::class, $provider2], + [LocalTimeProvider::class, $provider2], + [EMailProvider::class, $provider3], ]); $providers = $this->actionProviderStore->getProviders($user); - $this->assertCount(2, $providers); + $this->assertCount(3, $providers); $this->assertInstanceOf(ProfileProvider::class, $providers[0]); - $this->assertInstanceOf(EMailProvider::class, $providers[1]); + $this->assertInstanceOf(LocalTimeProvider::class, $providers[1]); + $this->assertInstanceOf(EMailProvider::class, $providers[2]); } -- 2.39.5