From 9b89e0ec65d10577363713a60e28a434651e9ea9 Mon Sep 17 00:00:00 2001
From: Olivier Lamy <olamy@apache.org>
Date: Thu, 3 Jan 2013 21:43:12 +0000
Subject: [PATCH] remove commented code caching will be in LdapRbacManager.

git-svn-id: https://svn.apache.org/repos/asf/archiva/redback/redback-core/trunk@1428613 13f79535-47bb-0310-9956-ffa450edef68
---
 .../rbac/ldap/DefaultLdapRoleMapper.java       | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/redback-rbac/redback-rbac-providers/redback-rbac-ldap/src/main/java/org/apache/archiva/redback/rbac/ldap/DefaultLdapRoleMapper.java b/redback-rbac/redback-rbac-providers/redback-rbac-ldap/src/main/java/org/apache/archiva/redback/rbac/ldap/DefaultLdapRoleMapper.java
index 4df4bc731..466ad2ed3 100644
--- a/redback-rbac/redback-rbac-providers/redback-rbac-ldap/src/main/java/org/apache/archiva/redback/rbac/ldap/DefaultLdapRoleMapper.java
+++ b/redback-rbac/redback-rbac-providers/redback-rbac-ldap/src/main/java/org/apache/archiva/redback/rbac/ldap/DefaultLdapRoleMapper.java
@@ -89,7 +89,6 @@ public class DefaultLdapRoleMapper
     public List<String> getAllGroups()
         throws MappingException
     {
-        // TODO caching
         LdapConnection ldapConnection = null;
 
         NamingEnumeration<SearchResult> namingEnumeration = null;
@@ -158,7 +157,6 @@ public class DefaultLdapRoleMapper
     public List<String> getGroupsMember( String group )
         throws MappingException
     {
-        // TODO caching
         LdapConnection ldapConnection = null;
 
         NamingEnumeration<SearchResult> namingEnumeration = null;
@@ -228,20 +226,6 @@ public class DefaultLdapRoleMapper
     public List<String> getGroups( String username )
         throws MappingException
     {
-        // TODO caching and a filter with uid
-
-        /*List<String> allGroups = getAllGroups();
-        List<String> userGroups = new ArrayList<String>();
-        for ( String group : allGroups )
-        {
-            List<String> users = getGroupsMember( group );
-            if ( users.contains( username ) )
-            {
-                userGroups.add( group );
-            }
-        }
-        return userGroups;
-        */
 
         List<String> userGroups = new ArrayList<String>();
 
@@ -285,8 +269,6 @@ public class DefaultLdapRoleMapper
                         // uid=blabla we only want bla bla
                         userName = StringUtils.substringAfter( userName, "=" );
                         userName = StringUtils.substringBefore( userName, "," );
-                        //log.debug( "found group for username {}: '{}", group, userName );
-
                         allMembers.add( userName );
                     }
                     close( allMembersEnum );
-- 
2.39.5