From 9dd5b3e9880fbbf3ae5bf5072edc61446587206e Mon Sep 17 00:00:00 2001
From: Brett Porter <brett@apache.org>
Date: Sat, 9 Sep 2006 15:51:32 +0000
Subject: [PATCH] clarify some TODO elements

git-svn-id: https://svn.apache.org/repos/asf/maven/archiva/trunk@441803 13f79535-47bb-0310-9956-ffa450edef68
---
 .../archiva/scheduler/DefaultRepositoryTaskScheduler.java     | 4 ++--
 .../maven/archiva/reporting/BadMetadataReportProcessor.java   | 2 +-
 .../java/org/apache/maven/archiva/web/action/ProxyAction.java | 2 +-
 .../web/action/admin/DeleteSyncedRepositoryAction.java        | 2 +-
 archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp   | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java b/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java
index 3db17e8ed..bee12f078 100644
--- a/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java
+++ b/archiva-core/src/main/java/org/apache/maven/archiva/scheduler/DefaultRepositoryTaskScheduler.java
@@ -97,7 +97,7 @@ public class DefaultRepositoryTaskScheduler
     private void scheduleJobs( Configuration configuration )
         throws ParseException, SchedulerException
     {
-        // TODO! would be nice to queue jobs that are triggered so we could avoid two running at the same time (so have a queue for discovery based jobs so they didn't thrash the repo)
+        // TODO: would be nice to queue jobs that are triggered so we could avoid two running at the same time (so have a queue for discovery based jobs so they didn't thrash the repo)
         if ( configuration.getIndexPath() != null )
         {
             JobDetail jobDetail = createJobDetail( INDEXER_JOB, indexerTask );
@@ -107,7 +107,7 @@ public class DefaultRepositoryTaskScheduler
                 new CronTrigger( INDEXER_JOB + "Trigger", DISCOVERER_GROUP, configuration.getIndexerCronExpression() );
             scheduler.scheduleJob( jobDetail, trigger );
 
-            // TODO: run as a job so it doesn't block startup/configuration saving!
+            // TODO: run as a job so it doesn't block startup/configuration saving
             try
             {
                 indexerTask.executeNowIfNeeded();
diff --git a/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java b/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java
index a307e16f2..907bed9b0 100644
--- a/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java
+++ b/archiva-reports-standard/src/main/java/org/apache/maven/archiva/reporting/BadMetadataReportProcessor.java
@@ -264,7 +264,7 @@ public class BadMetadataReportProcessor
         File versionsDir =
             new File( repository.getBasedir(), repository.pathOfRemoteRepositoryMetadata( metadata ) ).getParentFile();
 
-        // TODO! I don't know how this condition can happen, but it was seen on the main repository.
+        // TODO: I don't know how this condition can happen, but it was seen on the main repository.
         // Avoid hard failure
         if ( versionsDir.exists() )
         {
diff --git a/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java b/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java
index c7c57f16e..219dbfcae 100644
--- a/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java
+++ b/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/ProxyAction.java
@@ -58,7 +58,7 @@ public class ProxyAction
 
             artifactStream = new FileInputStream( file );
 
-            // TODO: could be better!
+            // TODO: set the correct content type and other headers!
             contentType = "application/octet-stream";
 
             filename = file.getName();
diff --git a/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java b/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java
index dc286c656..f562f33f5 100644
--- a/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java
+++ b/archiva-webapp/src/main/java/org/apache/maven/archiva/web/action/admin/DeleteSyncedRepositoryAction.java
@@ -43,6 +43,6 @@ public class DeleteSyncedRepositoryAction
     protected void removeContents( AbstractRepositoryConfiguration existingRepository )
         throws IOException
     {
-        // TODO!
+        // TODO! remove the contents
     }
 }
diff --git a/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp b/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp
index ce9d5eabf..d05ce8586 100644
--- a/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp
+++ b/archiva-webapp/src/main/webapp/WEB-INF/jsp/showArtifact.jsp
@@ -74,7 +74,7 @@
       <ww:url action="proxy">
         <%-- TODO! create a tag for this, include classifier for javadoc, sources below --%>
         <%-- TODO: what about other repositories? --%>
-        <%-- TODO! extension probably doesn't match type --%>
+        <%-- TODO! extension probably doesn't match type. Use artifact handler instead. --%>
         <ww:param name="path"
                   value="%{'${model.groupId}/${model.artifactId}/${model.version}/${model.artifactId}-${model.version}.${model.packaging}'}"/>
       </ww:url>
-- 
2.39.5