From a1d454a1b18f503a30805a29b55fccecf97e48d7 Mon Sep 17 00:00:00 2001
From: Go MAEDA <maeda@farend.jp>
Date: Sun, 18 Aug 2019 14:40:47 +0000
Subject: [PATCH] Add rubocop-performance (#31509).

git-svn-id: http://svn.redmine.org/redmine/trunk@18378 e93f8b46-1217-0410-a6f0-8f06a7374b81
---
 .rubocop.yml      |  1 +
 .rubocop_todo.yml | 64 +++++++++++++++++++++++++++++++++++++++++++++++
 Gemfile           |  1 +
 3 files changed, 66 insertions(+)

diff --git a/.rubocop.yml b/.rubocop.yml
index 10c3b50ec..91af1ddf1 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -17,6 +17,7 @@ AllCops:
 # Enable extensions
 
 require:
+  - rubocop-performance
   - rubocop-rails
 
 # Rules for Redmine
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 735b9bf54..9005a86ef 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -818,6 +818,70 @@ Naming/VariableNumber:
     - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb'
     - 'test/unit/project_test.rb'
 
+# Cop supports --auto-correct.
+Performance/Casecmp:
+  Exclude:
+    - 'lib/redmine/codeset_util.rb'
+    - 'lib/redmine/scm/adapters/bazaar_adapter.rb'
+
+Performance/FixedSize:
+  Exclude:
+    - 'test/integration/api_test/issues_test.rb'
+    - 'test/integration/attachments_test.rb'
+
+# Cop supports --auto-correct.
+Performance/InefficientHashSearch:
+  Exclude:
+    - 'test/functional/issues_custom_fields_visibility_test.rb'
+    - 'test/functional/search_custom_fields_visibility_test.rb'
+    - 'test/functional/timelog_custom_fields_visibility_test.rb'
+    - 'test/unit/lib/redmine/mime_type_test.rb'
+    - 'test/unit/query_test.rb'
+
+# Cop supports --auto-correct.
+Performance/RedundantBlockCall:
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'lib/redmine/views/builders/structure.rb'
+    - 'test/functional/repositories_git_controller_test.rb'
+    - 'test/unit/lib/redmine/views/builders/json_test.rb'
+    - 'test/unit/lib/redmine/views/builders/xml_test.rb'
+
+# Cop supports --auto-correct.
+Performance/RedundantMatch:
+  Exclude:
+    - 'app/controllers/auto_completes_controller.rb'
+    - 'app/models/issue_relation.rb'
+    - 'lib/redmine/wiki_formatting/textile/formatter.rb'
+    - 'lib/redmine/wiki_formatting/textile/redcloth3.rb'
+
+# Cop supports --auto-correct.
+# Configuration parameters: MaxKeyValuePairs.
+Performance/RedundantMerge:
+  Exclude:
+    - 'app/controllers/issues_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/avatars_helper.rb'
+    - 'app/helpers/custom_fields_helper.rb'
+    - 'app/helpers/workflows_helper.rb'
+    - 'app/models/auth_source_ldap.rb'
+    - 'app/models/principal.rb'
+    - 'lib/redmine/access_control.rb'
+    - 'test/functional/imports_controller_test.rb'
+    - 'test/unit/issue_import_test.rb'
+    - 'test/unit/time_entry_import_test.rb'
+
+# Cop supports --auto-correct.
+Performance/StringReplacement:
+  Exclude:
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/imports_helper.rb'
+    - 'app/helpers/settings_helper.rb'
+    - 'lib/redmine/core_ext/string/conversions.rb'
+    - 'lib/redmine/wiki_formatting/textile/redcloth3.rb'
+    - 'test/helpers/application_helper_test.rb'
+    - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb'
+
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
 Rails/ActiveRecordOverride:
diff --git a/Gemfile b/Gemfile
index 12fc054fb..f6856d3c5 100644
--- a/Gemfile
+++ b/Gemfile
@@ -85,6 +85,7 @@ group :test do
   gem "selenium-webdriver"
   # RuboCop
   gem 'rubocop', '~> 0.74.0'
+  gem 'rubocop-performance', '~> 1.4.1'
   gem 'rubocop-rails', '~> 2.3.0'
 end
 
-- 
2.39.5