From a242fea6973dd970de338d29fa138d8516fcb85d Mon Sep 17 00:00:00 2001 From: =?utf8?q?C=C3=A9dric=20Walter?= Date: Mon, 31 Mar 2014 16:16:52 +0000 Subject: [PATCH] performance issue: removed instantiation of new String object by copying an existing string. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1583366 13f79535-47bb-0310-9956-ffa450edef68 --- src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java | 2 +- src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java b/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java index 126bfe6817..a170256ac2 100644 --- a/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java +++ b/src/scratchpad/src/org/apache/poi/hwpf/dev/RecordUtil.java @@ -35,7 +35,7 @@ public class RecordUtil { String type = getBitFieldType( name, bitMask, parentType ); - String retVal = new String(); + String retVal = ""; if ( withType.equals( "true" ) ) { retVal = type + " "; diff --git a/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java b/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java index f514a9514a..94b8223de9 100644 --- a/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java +++ b/src/scratchpad/src/org/apache/poi/hwpf/model/Xst.java @@ -144,6 +144,6 @@ public class Xst @Override public String toString() { - return new String( "Xst [" + _cch + "; " + _rgtchar + "]" ); + return "Xst [" + _cch + "; " + _rgtchar + "]"; } } -- 2.39.5