From a547283bb4bb430ad7ea7a457bd6c9c5274efd7d Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Wed, 14 Dec 2011 17:41:48 +0100 Subject: [PATCH] Decrease visibility of some methods of org.sonar.persistence.review.ReviewQuery --- .../main/java/org/sonar/persistence/review/ReviewQuery.java | 4 ++-- .../java/org/sonar/persistence/review/ReviewDaoTest.java | 5 ----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java b/sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java index 8f3cdda15bb..ed649d62840 100644 --- a/sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java +++ b/sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java @@ -128,11 +128,11 @@ public final class ReviewQuery { return this; } - protected boolean needToPartitionQuery() { + boolean needToPartitionQuery() { return violationPermanentIds != null && violationPermanentIds.size() > DatabaseUtils.MAX_IN_ELEMENTS; } - public ReviewQuery[] partition() { + ReviewQuery[] partition() { List> partitions = Lists.partition(violationPermanentIds, DatabaseUtils.MAX_IN_ELEMENTS); ReviewQuery[] result = new ReviewQuery[partitions.size()]; for (int index = 0; index < partitions.size(); index++) { diff --git a/sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java b/sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java index 4e776f276a6..18c9beb948d 100644 --- a/sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java +++ b/sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java @@ -25,9 +25,6 @@ import org.hamcrest.Description; import org.junit.Before; import org.junit.Test; import org.sonar.persistence.DaoTestCase; -import org.sonar.persistence.review.ReviewDao; -import org.sonar.persistence.review.ReviewDto; -import org.sonar.persistence.review.ReviewQuery; import java.util.List; @@ -131,8 +128,6 @@ public class ReviewDaoTest extends DaoTestCase { public boolean matches(Object o) { ReviewDto reviewDto = (ReviewDto) o; - System.out.println(reviewDto.getViolationPermanentId()); - return expectedId.equals(reviewDto.getViolationPermanentId()); } -- 2.39.5