From a7016170cfbb9bc842d4a5efc2539b9bd9add13f Mon Sep 17 00:00:00 2001 From: Christopher Ng Date: Fri, 2 Sep 2022 01:38:13 +0000 Subject: [PATCH] Accessibility improvements to unified search Signed-off-by: Christopher Ng --- core/src/components/HeaderMenu.vue | 4 +- .../components/UnifiedSearch/SearchResult.vue | 10 +- core/src/views/UnifiedSearch.vue | 116 +++++++++++------- dist/core-unified-search.js | 4 +- dist/core-unified-search.js.map | 2 +- 5 files changed, 79 insertions(+), 57 deletions(-) diff --git a/core/src/components/HeaderMenu.vue b/core/src/components/HeaderMenu.vue index fc8936ba07c..9a78b769dc3 100644 --- a/core/src/components/HeaderMenu.vue +++ b/core/src/components/HeaderMenu.vue @@ -29,7 +29,6 @@ :aria-label="ariaLabel" :aria-controls="`header-menu-${id}`" :aria-expanded="opened.toString()" - aria-haspopup="menu" @click.prevent="toggleMenu"> @@ -195,8 +194,9 @@ export default { margin: 0; border-radius: 0 0 var(--border-radius) var(--border-radius); background-color: var(--color-main-background); - filter: drop-shadow(0 1px 5px var(--color-box-shadow)); + padding: 20px; + border-radius: var(--border-radius-large); } &__carret { diff --git a/core/src/components/UnifiedSearch/SearchResult.vue b/core/src/components/UnifiedSearch/SearchResult.vue index dfd20868480..9c787de111c 100644 --- a/core/src/components/UnifiedSearch/SearchResult.vue +++ b/core/src/components/UnifiedSearch/SearchResult.vue @@ -38,8 +38,7 @@ }" :style="{ backgroundImage: isIconUrl ? `url(${icon})` : '', - }" - role="img"> + }"> -

+ -

-

{{ subline }}

+
+ {{ subline }} @@ -173,6 +172,7 @@ $margin: 10px; height: $clickable-area; padding: $margin; border-bottom: 1px solid var(--color-border); + border-radius: var(--border-radius-large) !important; // Load more entry, &:last-child { diff --git a/core/src/views/UnifiedSearch.vue b/core/src/views/UnifiedSearch.vue index 32e3073b3aa..e7d3f9d5809 100644 --- a/core/src/views/UnifiedSearch.vue +++ b/core/src/views/UnifiedSearch.vue @@ -36,45 +36,53 @@
- - - - - - {{ `in:${type}` }} - - + +
+ + + + + + {{ `in:${type}` }} + + +