From aa39b79abe152872df7630316cfa39bf093236e3 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Gr=C3=A9goire=20Aubert?= <gregoire.aubert@sonarsource.com>
Date: Mon, 2 Oct 2017 17:19:52 +0200
Subject: [PATCH] SONAR-9545 Better wording when searching for a project in My
 Favorites scope

---
 .../apps/projects/components/AllProjects.tsx  |  1 +
 .../components/EmptyFavoriteSearch.tsx        | 42 +++++++++++++++++++
 .../apps/projects/components/ProjectsList.tsx | 13 +++---
 .../__snapshots__/AllProjects-test.tsx.snap   |  1 +
 .../resources/org/sonar/l10n/core.properties  |  2 +
 5 files changed, 53 insertions(+), 6 deletions(-)
 create mode 100644 server/sonar-web/src/main/js/apps/projects/components/EmptyFavoriteSearch.tsx

diff --git a/server/sonar-web/src/main/js/apps/projects/components/AllProjects.tsx b/server/sonar-web/src/main/js/apps/projects/components/AllProjects.tsx
index d0c700dbc1b..deb67d0892e 100644
--- a/server/sonar-web/src/main/js/apps/projects/components/AllProjects.tsx
+++ b/server/sonar-web/src/main/js/apps/projects/components/AllProjects.tsx
@@ -271,6 +271,7 @@ export default class AllProjects extends React.PureComponent<Props, State> {
             isFiltered={this.isFiltered()}
             organization={this.props.organization}
             projects={this.state.projects}
+            query={this.state.query}
           />
         )}
         <ListFooter
diff --git a/server/sonar-web/src/main/js/apps/projects/components/EmptyFavoriteSearch.tsx b/server/sonar-web/src/main/js/apps/projects/components/EmptyFavoriteSearch.tsx
new file mode 100644
index 00000000000..220295cbe2d
--- /dev/null
+++ b/server/sonar-web/src/main/js/apps/projects/components/EmptyFavoriteSearch.tsx
@@ -0,0 +1,42 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2017 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+import * as React from 'react';
+import { FormattedMessage } from 'react-intl';
+import { Link } from 'react-router';
+import { translate } from '../../../helpers/l10n';
+import { Query } from '../query';
+import '../../../components/common/EmptySearch.css';
+
+export default function EmptyFavoriteSearch({ query }: { query: Query }) {
+  return (
+    <div className="empty-search">
+      <h3>{translate('no_results_search.favorites')}</h3>
+      <p className="big-spacer-top">
+        <FormattedMessage
+          defaultMessage={translate('no_results_search.favorites.2')}
+          id="no_results_search.favorites.2"
+          values={{
+            url: <Link to={{ pathname: '/projects', query }}>{translate('all')}</Link>
+          }}
+        />
+      </p>
+    </div>
+  );
+}
diff --git a/server/sonar-web/src/main/js/apps/projects/components/ProjectsList.tsx b/server/sonar-web/src/main/js/apps/projects/components/ProjectsList.tsx
index 6636307001a..423da0dcd26 100644
--- a/server/sonar-web/src/main/js/apps/projects/components/ProjectsList.tsx
+++ b/server/sonar-web/src/main/js/apps/projects/components/ProjectsList.tsx
@@ -21,8 +21,10 @@ import * as React from 'react';
 import ProjectCard from './ProjectCard';
 import NoFavoriteProjects from './NoFavoriteProjects';
 import EmptyInstance from './EmptyInstance';
+import EmptyFavoriteSearch from './EmptyFavoriteSearch';
 import EmptySearch from '../../../components/common/EmptySearch';
 import { Project } from '../types';
+import { Query } from '../query';
 
 interface Props {
   cardType?: string;
@@ -30,17 +32,16 @@ interface Props {
   isFiltered: boolean;
   organization?: { key: string };
   projects: Project[];
+  query: Query;
 }
 
 export default class ProjectsList extends React.PureComponent<Props> {
   renderNoProjects() {
-    if (this.props.isFavorite && !this.props.isFiltered) {
-      return <NoFavoriteProjects />;
-    } else if (!this.props.isFiltered) {
-      return <EmptyInstance />;
-    } else {
-      return <EmptySearch />;
+    const { isFavorite, isFiltered, query } = this.props;
+    if (isFiltered) {
+      return isFavorite ? <EmptyFavoriteSearch query={query} /> : <EmptySearch />;
     }
+    return isFavorite ? <NoFavoriteProjects /> : <EmptyInstance />;
   }
 
   render() {
diff --git a/server/sonar-web/src/main/js/apps/projects/components/__tests__/__snapshots__/AllProjects-test.tsx.snap b/server/sonar-web/src/main/js/apps/projects/components/__tests__/__snapshots__/AllProjects-test.tsx.snap
index 2561502915e..fc7e90eddd2 100644
--- a/server/sonar-web/src/main/js/apps/projects/components/__tests__/__snapshots__/AllProjects-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/projects/components/__tests__/__snapshots__/AllProjects-test.tsx.snap
@@ -91,6 +91,7 @@ exports[`renders 1`] = `
             },
           ]
         }
+        query={Object {}}
       />
       <ListFooter
         count={1}
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index fcb14bef307..ad305f96387 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -208,7 +208,9 @@ no_data=No data
 no_results=No results
 no_results_for_x=No results for "{0}"
 no_results_search=We couldn't find any results matching selected criteria.
+no_results_search.favorites=We couldn't find any results matching selected criteria in your favorites.
 no_results_search.2=Try to change filters to get some results.
+no_results_search.favorites.2=Would you like to search among {url} projects?
 page_extension_failed=Page extension failed.
 set_as_default=Set as Default
 unset_as_default=Unset as Default
-- 
2.39.5