From ac46595adb827cbc615fa6cb2702d00f7bf41937 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Thu, 11 Jul 2013 12:54:11 +0200 Subject: [PATCH] Fix quality flaws --- .../main/java/org/sonar/api/config/PropertyDefinition.java | 6 +++--- .../org/sonar/server/issue/InternalRubyIssueService.java | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/config/PropertyDefinition.java b/sonar-plugin-api/src/main/java/org/sonar/api/config/PropertyDefinition.java index 038c7182c20..2bd49827409 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/config/PropertyDefinition.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/config/PropertyDefinition.java @@ -157,21 +157,21 @@ public final class PropertyDefinition implements BatchExtension, ServerExtension return Result.SUCCESS; } - private static Result validateBoolean(@Nullable String value) { + private static Result validateBoolean(String value) { if (!StringUtils.equalsIgnoreCase(value, "true") && !StringUtils.equalsIgnoreCase(value, "false")) { return Result.newError("notBoolean"); } return Result.SUCCESS; } - private static Result validateInteger(@Nullable String value) { + private static Result validateInteger(String value) { if (!NumberUtils.isDigits(value)) { return Result.newError("notInteger"); } return Result.SUCCESS; } - private static Result validateFloat(@Nullable String value) { + private static Result validateFloat(String value) { try { Double.parseDouble(value); return Result.SUCCESS; diff --git a/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java b/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java index 702da148d3d..7d657d98751 100644 --- a/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java +++ b/sonar-server/src/main/java/org/sonar/server/issue/InternalRubyIssueService.java @@ -62,9 +62,9 @@ import java.util.Map; */ public class InternalRubyIssueService implements ServerComponent { - private final static String ID_PARAM = "id"; - private final static String NAME_PARAM = "name"; - private final static String DESCRIPTION_PARAM = "description"; + private static final String ID_PARAM = "id"; + private static final String NAME_PARAM = "name"; + private static final String DESCRIPTION_PARAM = "description"; private final IssueService issueService; private final IssueCommentService commentService; -- 2.39.5