From ae188fbbf4d9871adff1815fa4d69c7c0fc62104 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Fri, 17 May 2013 20:02:40 +0200 Subject: [PATCH] SONAR-3755 remove unused methods in issue ws client --- .../java/org/sonar/wsclient/issue/Issue.java | 17 ----------------- .../org/sonar/wsclient/issue/IssueQuery.java | 7 ------- .../sonar/wsclient/issue/IssueParserTest.java | 4 ++-- 3 files changed, 2 insertions(+), 26 deletions(-) diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issue.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issue.java index 69cab8fc29c..c00f4d25f0e 100644 --- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issue.java +++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/Issue.java @@ -54,14 +54,6 @@ public class Issue { return JsonUtils.getString(json, "severity"); } - /** - * TODO to be removed - */ - @CheckForNull - public String description() { - return JsonUtils.getString(json, "message"); - } - @CheckForNull public String message() { return JsonUtils.getString(json, "message"); @@ -89,15 +81,6 @@ public class Issue { return JsonUtils.getString(json, "resolution"); } - /** - * Login of the user who created the manual issue, else null. - * TODO to be removed - */ - @CheckForNull - public String userLogin() { - return JsonUtils.getString(json, "reporter"); - } - @CheckForNull public String reporter() { return JsonUtils.getString(json, "reporter"); diff --git a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/IssueQuery.java b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/IssueQuery.java index 204e90c6f54..db597021e08 100644 --- a/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/IssueQuery.java +++ b/sonar-ws-client/src/main/java/org/sonar/wsclient/issue/IssueQuery.java @@ -76,13 +76,6 @@ public class IssueQuery { return addParam("actionPlans", s); } - /** - * TODO To be removed - */ - public IssueQuery userLogins(String... s) { - return addParam("reporters", s); - } - public IssueQuery reporters(String... s) { return addParam("reporters", s); } diff --git a/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/IssueParserTest.java b/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/IssueParserTest.java index 2b2cb50984b..1d84ad11cbc 100644 --- a/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/IssueParserTest.java +++ b/sonar-ws-client/src/test/java/org/sonar/wsclient/issue/IssueParserTest.java @@ -47,7 +47,7 @@ public class IssueParserTest { assertThat(first.assignee()).isEqualTo("karadoc"); assertThat(first.message()).isEqualTo("the message"); assertThat(first.effortToFix()).isEqualTo(4.2); - assertThat(first.userLogin()).isEqualTo("perceval"); + assertThat(first.reporter()).isEqualTo("perceval"); assertThat(first.creationDate()).isNotNull(); assertThat(first.updateDate()).isNotNull(); assertThat(first.closeDate()).isNotNull(); @@ -60,7 +60,7 @@ public class IssueParserTest { assertThat(second.key()).isEqualTo("FGHIJ"); assertThat(second.line()).isNull(); assertThat(second.effortToFix()).isNull(); - assertThat(second.description()).isNull(); + assertThat(second.reporter()).isNull(); assertThat(second.attribute("JIRA")).isNull(); assertThat(second.attributes()).isEmpty(); assertThat(second.comments()).isEmpty(); -- 2.39.5