From b0875cadc20e36c19490c5d8effd64c30e2d901b Mon Sep 17 00:00:00 2001 From: Pierre Ossman Date: Thu, 26 Mar 2020 08:50:04 +0100 Subject: [PATCH] Avoid using insecure variable length arrays --- common/rdr/Exception.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/rdr/Exception.cxx b/common/rdr/Exception.cxx index 9b6096b6..f4e23836 100644 --- a/common/rdr/Exception.cxx +++ b/common/rdr/Exception.cxx @@ -57,10 +57,11 @@ GAIException::GAIException(const char* s, int err) { strncat(str_, ": ", len-1-strlen(str_)); #ifdef _WIN32 - wchar_t currStr[len-strlen(str_)]; + wchar_t *currStr = new wchar_t[len-strlen(str_)]; wcsncpy(currStr, gai_strerrorW(err), len-1-strlen(str_)); WideCharToMultiByte(CP_UTF8, 0, currStr, -1, str_+strlen(str_), len-1-strlen(str_), 0, 0); + delete [] currStr; #else //FIXME: perhaps print the error number (NNNN) strncat(str_, gai_strerror(err), len-1-strlen(str_)); -- 2.39.5