From b290b1bce2e1f7525565e30942fdd4b755340124 Mon Sep 17 00:00:00 2001 From: Nick Burch Date: Wed, 12 Dec 2012 00:48:13 +0000 Subject: [PATCH] Patch from Jan from bug #54282 - Improve the performance of ColumnHelper addCleanColIntoCols, speeds up some .xlsx file loading git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1420501 13f79535-47bb-0310-9956-ffa450edef68 --- src/documentation/content/xdocs/status.xml | 1 + .../org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/documentation/content/xdocs/status.xml b/src/documentation/content/xdocs/status.xml index b8b3e81d21..8fef9acb23 100644 --- a/src/documentation/content/xdocs/status.xml +++ b/src/documentation/content/xdocs/status.xml @@ -34,6 +34,7 @@ + 54282 - Improve the performance of ColumnHelper addCleanColIntoCols, speeds up some .xlsx file loading 53650 - Prevent unreadable content and disalow to overwrite rows from input template in SXSSF 54228,53672 - Fixed XSSF to read cells with missing R attribute 54206 - Ensure that shared formuals are updated when shifting rows in a spreadsheet diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java index 3655affc44..46ca2f6737 100644 --- a/src/ooxml/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java +++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/helpers/ColumnHelper.java @@ -112,7 +112,8 @@ public class ColumnHelper { public CTCols addCleanColIntoCols(CTCols cols, CTCol col) { boolean colOverlaps = false; - for (int i = 0; i < cols.sizeOfColArray(); i++) { + int sizeOfColArray = cols.sizeOfColArray(); + for (int i = 0; i < sizeOfColArray; i++) { CTCol ithCol = cols.getColArray(i); long[] range1 = { ithCol.getMin(), ithCol.getMax() }; long[] range2 = { col.getMin(), col.getMax() }; -- 2.39.5