From b39d57cc2149a922928b92e9969c76ed09c60d1e Mon Sep 17 00:00:00 2001 From: Stephane Gamard Date: Sat, 10 May 2014 15:09:37 +0200 Subject: [PATCH] Fixed some basic tests for RegisterRule with DAOv.2 --- .../java/org/sonar/core/rule/RuleDto.java | 4 +- .../org/sonar/server/rule2/RegisterRules.java | 1 + .../sonar/server/rule2/RegisterRulesTest.java | 77 +++++++------------ ...e_deprecated_active_rule_params-result.xml | 4 +- .../disable_deprecated_active_rule_params.xml | 2 +- ...disable_deprecated_active_rules-result.xml | 8 +- .../disable_deprecated_active_rules.xml | 4 +- ...disable_deprecated_repositories-result.xml | 6 +- .../disable_deprecated_rules-result.xml | 8 +- .../disable_deprecated_rules.xml | 4 +- ...ate_rules_if_parent_is_disabled-result.xml | 12 +-- ...e_template_rules_if_parent_is_disabled.xml | 8 +- ..._rule_is_linked_on_root_characteristic.xml | 4 +- .../insert_extended_repositories-result.xml | 4 +- .../insert_new_rules-result.xml | 6 +- ..._disable_already_disabled_rules-result.xml | 8 +- .../not_disable_already_disabled_rules.xml | 4 +- .../not_disable_manual_rules-result.xml | 8 +- .../not_disable_manual_rules.xml | 4 +- ...late_rules_if_parent_is_enabled-result.xml | 6 +- ...le_template_rules_if_parent_is_enabled.xml | 4 +- ...t_update_already_disabled_rules-result.xml | 4 +- .../not_update_already_disabled_rules.xml | 2 +- ...ules_when_repository_is_still_existing.xml | 2 +- .../reactivate_disabled_rules-result.xml | 4 +- .../reactivate_disabled_rules.xml | 2 +- ...ctivate_disabled_template_rules-result.xml | 6 +- .../reactivate_disabled_template_rules.xml | 4 +- ...c_when_characteristic_not_found-result.xml | 4 +- ...teristic_when_characteristic_not_found.xml | 4 +- ...rriding_characteristic_disabled-result.xml | 4 +- ...and_overriding_characteristic_disabled.xml | 4 +- ...racteristic_has_been_overridden-result.xml | 4 +- ...but_characteristic_has_been_overridden.xml | 4 +- .../server/rule2/RegisterRulesTest/shared.xml | 2 +- ...ame_and_description_in_database-result.xml | 4 +- .../update_rule_fields-result.xml | 2 +- .../RegisterRulesTest/update_rule_fields.xml | 2 +- .../update_rule_parameters-result.xml | 4 +- .../update_rule_parameters.xml | 4 +- .../update_template_rule_language-result.xml | 8 +- .../update_template_rule_language.xml | 8 +- 42 files changed, 124 insertions(+), 144 deletions(-) diff --git a/sonar-core/src/main/java/org/sonar/core/rule/RuleDto.java b/sonar-core/src/main/java/org/sonar/core/rule/RuleDto.java index 6ce40e81d3c..88ba9c64fb3 100644 --- a/sonar-core/src/main/java/org/sonar/core/rule/RuleDto.java +++ b/sonar-core/src/main/java/org/sonar/core/rule/RuleDto.java @@ -343,12 +343,12 @@ public final class RuleDto implements Dto { } public RuleDto setTags(Set tags) { - this.tags = StringUtils.join(tags, ','); + this.tags = tags.isEmpty()?null:StringUtils.join(tags, ','); return this; } public RuleDto setSystemTags(Set tags) { - this.systemTags = StringUtils.join(tags, ','); + this.systemTags = tags.isEmpty()?null:StringUtils.join(tags, ','); return this; } diff --git a/sonar-server/src/main/java/org/sonar/server/rule2/RegisterRules.java b/sonar-server/src/main/java/org/sonar/server/rule2/RegisterRules.java index 64aaa428dba..f9d5f456ca3 100644 --- a/sonar-server/src/main/java/org/sonar/server/rule2/RegisterRules.java +++ b/sonar-server/src/main/java/org/sonar/server/rule2/RegisterRules.java @@ -77,6 +77,7 @@ public class RegisterRules implements Startable { this(defLoader, profilesManager, myBatis, ruleDao, activeRuleDao, characteristicDao, System2.INSTANCE); } + @VisibleForTesting RegisterRules(RuleDefinitionsLoader defLoader, ProfilesManager profilesManager, MyBatis myBatis, RuleDao ruleDao, ActiveRuleDao activeRuleDao, diff --git a/sonar-server/src/test/java/org/sonar/server/rule2/RegisterRulesTest.java b/sonar-server/src/test/java/org/sonar/server/rule2/RegisterRulesTest.java index 8963e627146..89428a63f35 100644 --- a/sonar-server/src/test/java/org/sonar/server/rule2/RegisterRulesTest.java +++ b/sonar-server/src/test/java/org/sonar/server/rule2/RegisterRulesTest.java @@ -19,10 +19,8 @@ */ package org.sonar.server.rule2; -import org.apache.ibatis.session.SqlSession; import org.junit.After; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.ArgumentCaptor; @@ -49,14 +47,12 @@ import org.sonar.server.rule.ESRuleTags; import org.sonar.server.rule.RuleDefinitionsLoader; import org.sonar.server.rule.RuleRegistry; import org.sonar.server.rule.RuleRepositories; -import org.sonar.server.rule.RuleTagOperations; import java.util.Collection; import java.util.Date; import static org.fest.assertions.Assertions.assertThat; import static org.fest.assertions.Fail.fail; -import static org.mockito.Matchers.any; import static org.mockito.Mockito.*; @RunWith(MockitoJUnitRunner.class) @@ -85,7 +81,6 @@ public class RegisterRulesTest extends AbstractDaoTestCase { @Captor ArgumentCaptor> ruleTagsCaptor; - RuleTagOperations ruleTagOperations; MyBatis myBatis; RuleDao ruleDao; RuleTagDao ruleTagDao; @@ -105,7 +100,6 @@ public class RegisterRulesTest extends AbstractDaoTestCase { ruleDao = new RuleDao(); ruleTagDao = new RuleTagDao(myBatis); activeRuleDao = new ActiveRuleDao(new QualityProfileDao(myBatis), ruleDao); - ruleTagOperations = new RuleTagOperations(ruleTagDao, esRuleTags); characteristicDao = new CharacteristicDao(myBatis); task = new RegisterRules(new RuleDefinitionsLoader(mock(RuleRepositories.class), new RulesDefinition[]{new FakeRepository()}), profilesManager, myBatis, ruleDao, activeRuleDao, characteristicDao, system); @@ -113,27 +107,10 @@ public class RegisterRulesTest extends AbstractDaoTestCase { } @After - public void after(){ + public void after() { session.close(); } - - @Test - @Ignore - public void insert_new_rules() { - setupData("shared"); - task.start(); - - verify(ruleRegistry).reindex(rulesCaptor.capture(), any(SqlSession.class)); - assertThat(rulesCaptor.getValue()).hasSize(3); - verify(ruleRegistry).removeDeletedRules(any(String[].class)); - - verify(esRuleTags).putAllTags(ruleTagsCaptor.capture()); - assertThat(ruleTagsCaptor.getValue()).hasSize(3); - - checkTables("insert_new_rules", EXCLUDED_COLUMN_NAMES, "rules", "rules_parameters", "rules_rule_tags", "rule_tags"); - } - @Test public void update_template_rule_language() { setupData("update_template_rule_language"); @@ -298,32 +275,34 @@ public class RegisterRulesTest extends AbstractDaoTestCase { checkTables("not_disable_manual_rules", EXCLUDED_COLUMN_NAMES_INCLUDING_DEBT, "rules"); } -// @Test -// public void test_high_number_of_rules() { -// task = new RegisterRules(new RuleDefinitionsLoader(mock(RuleRepositories.class), new RulesDefinition[]{new BigRepository()}), -// profilesManager, ruleTagOperations, myBatis, ruleDao, activeRuleDao, characteristicDao, mock(RegisterDebtModel.class)); -// -// setupData("shared"); -// task.start(); -// -// // There is already one rule in DB -// assertThat(ruleDao.selectAll()).hasSize(BigRepository.SIZE + 1); -// assertThat(ruleDao.selectParameters()).hasSize(BigRepository.SIZE * 20); + @Test + public void test_high_number_of_rules() { + task = new RegisterRules(new RuleDefinitionsLoader(mock(RuleRepositories.class), new RulesDefinition[]{new BigRepository()}), + profilesManager, myBatis, ruleDao, activeRuleDao, characteristicDao); + + setupData("shared"); + task.start(); + + + // There is already one rule in DB + assertThat(ruleDao.findAll(session)).hasSize(BigRepository.SIZE + 1); + assertThat(ruleDao.findAllRuleParams(session)).hasSize(BigRepository.SIZE * 20); // assertThat(ruleDao.selectTags(getMyBatis().openSession(false))).hasSize(BigRepository.SIZE * 3); -// } - -// @Test -// public void insert_extended_repositories() { -// task = new RegisterRules(new RuleDefinitionsLoader(mock(RuleRepositories.class), new RulesDefinition[]{ -// new FindbugsRepository(), new FbContribRepository()}), -// profilesManager, ruleRegistry, esRuleTags, ruleTagOperations, myBatis, ruleDao, ruleTagDao, activeRuleDao, characteristicDao, mock(RegisterDebtModel.class) -// ); -// -// setupData("empty"); -// task.start(); -// -// checkTables("insert_extended_repositories", EXCLUDED_COLUMN_NAMES_INCLUDING_DEBT, "rules"); -// } + } + + @Test + public void insert_extended_repositories() { + task = new RegisterRules(new RuleDefinitionsLoader(mock(RuleRepositories.class), new RulesDefinition[]{ + new FindbugsRepository(), new FbContribRepository()}), + profilesManager, myBatis, ruleDao, activeRuleDao, characteristicDao + ); + + + setupData("empty"); + task.start(); + + checkTables("insert_extended_repositories", EXCLUDED_COLUMN_NAMES_INCLUDING_DEBT, "rules"); + } static class FakeRepository implements RulesDefinition { @Override diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rule_params-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rule_params-result.xml index e62e97a793d..dfa2ccff019 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rule_params-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rule_params-result.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rule_params.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rule_params.xml index 5b6e2bc90ed..bf310a09b6a 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rule_params.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rule_params.xml @@ -1,6 +1,6 @@ - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rules-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rules-result.xml index 4994d92912a..1616973e23e 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rules-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rules-result.xml @@ -1,15 +1,15 @@ - - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rules.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rules.xml index e93d82a6fde..8957a2373d4 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rules.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_active_rules.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_repositories-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_repositories-result.xml index f62bcfb60d1..f350c52f77b 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_repositories-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_repositories-result.xml @@ -1,9 +1,9 @@ - - @@ -11,7 +11,7 @@ - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_rules-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_rules-result.xml index 0a9bf6572c3..a19bf8bb48a 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_rules-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_rules-result.xml @@ -1,20 +1,20 @@ - - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_rules.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_rules.xml index 877df431166..d13c0db742f 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_rules.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_deprecated_rules.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_template_rules_if_parent_is_disabled-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_template_rules_if_parent_is_disabled-result.xml index 9d0e154fead..81682535971 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_template_rules_if_parent_is_disabled-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_template_rules_if_parent_is_disabled-result.xml @@ -1,21 +1,21 @@ - - - - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_template_rules_if_parent_is_disabled.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_template_rules_if_parent_is_disabled.xml index 6091a6bd195..d3e61274471 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_template_rules_if_parent_is_disabled.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/disable_template_rules_if_parent_is_disabled.xml @@ -1,19 +1,19 @@ - - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/ignore_rule_debt_definitions_if_rule_is_linked_on_root_characteristic.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/ignore_rule_debt_definitions_if_rule_is_linked_on_root_characteristic.xml index 55f29c2f961..d5dfe74dd1c 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/ignore_rule_debt_definitions_if_rule_is_linked_on_root_characteristic.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/ignore_rule_debt_definitions_if_rule_is_linked_on_root_characteristic.xml @@ -2,7 +2,7 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/insert_extended_repositories-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/insert_extended_repositories-result.xml index 680cb48eac0..5ad7d6d57d1 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/insert_extended_repositories-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/insert_extended_repositories-result.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/insert_new_rules-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/insert_new_rules-result.xml index 8bd8da0698b..0578a3d9262 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/insert_new_rules-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/insert_new_rules-result.xml @@ -1,6 +1,6 @@ - - - - - - - - - - - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_manual_rules.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_manual_rules.xml index 832e52b92b6..7f175d92749 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_manual_rules.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_manual_rules.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_template_rules_if_parent_is_enabled-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_template_rules_if_parent_is_enabled-result.xml index 0c26b40b517..446bbc47029 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_template_rules_if_parent_is_enabled-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_template_rules_if_parent_is_enabled-result.xml @@ -1,12 +1,12 @@ - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_template_rules_if_parent_is_enabled.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_template_rules_if_parent_is_enabled.xml index 60fffd2389a..8e3bcfb804d 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_template_rules_if_parent_is_enabled.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_disable_template_rules_if_parent_is_enabled.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_update_already_disabled_rules-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_update_already_disabled_rules-result.xml index 2f2f453533a..91f0b991742 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_update_already_disabled_rules-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_update_already_disabled_rules-result.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_update_already_disabled_rules.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_update_already_disabled_rules.xml index 56d37d8e543..45e3706d700 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_update_already_disabled_rules.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/not_update_already_disabled_rules.xml @@ -1,6 +1,6 @@ - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/notify_for_removed_rules_when_repository_is_still_existing.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/notify_for_removed_rules_when_repository_is_still_existing.xml index 0e6a0aa4968..f4e73c9239b 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/notify_for_removed_rules_when_repository_is_still_existing.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/notify_for_removed_rules_when_repository_is_still_existing.xml @@ -1,6 +1,6 @@ - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_rules-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_rules-result.xml index 13c41591aa5..fe4c1ce3506 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_rules-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_rules-result.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_rules.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_rules.xml index 3ab3113fd4d..d5b82972127 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_rules.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_rules.xml @@ -1,6 +1,6 @@ - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_template_rules-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_template_rules-result.xml index 97231e50ef3..518b25fb992 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_template_rules-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_template_rules-result.xml @@ -1,12 +1,12 @@ - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_template_rules.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_template_rules.xml index b80f5711a04..3982ccb7ca7 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_template_rules.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/reactivate_disabled_template_rules.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/set_no_characteristic_when_characteristic_not_found-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/set_no_characteristic_when_characteristic_not_found-result.xml index b458b548fef..681ce324eaf 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/set_no_characteristic_when_characteristic_not_found-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/set_no_characteristic_when_characteristic_not_found-result.xml @@ -1,6 +1,6 @@ - - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/set_no_characteristic_when_default_characteristic_not_found_and_overriding_characteristic_disabled-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/set_no_characteristic_when_default_characteristic_not_found_and_overriding_characteristic_disabled-result.xml index 728e44a7c18..63d0aaf3239 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/set_no_characteristic_when_default_characteristic_not_found_and_overriding_characteristic_disabled-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/set_no_characteristic_when_default_characteristic_not_found_and_overriding_characteristic_disabled-result.xml @@ -1,6 +1,6 @@ - - - - - - - - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/store_bundle_name_and_description_in_database-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/store_bundle_name_and_description_in_database-result.xml index ea262565bb6..1cfe02dd4ab 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/store_bundle_name_and_description_in_database-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/store_bundle_name_and_description_in_database-result.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_fields-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_fields-result.xml index 7214b9a16f0..9bbd5d720a8 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_fields-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_fields-result.xml @@ -12,7 +12,7 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_parameters-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_parameters-result.xml index 56fce29d554..08777a3cbfb 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_parameters-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_parameters-result.xml @@ -1,11 +1,11 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_parameters.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_parameters.xml index ff8c90bae1c..f1037dcb3f5 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_parameters.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_rule_parameters.xml @@ -1,9 +1,9 @@ - - diff --git a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_template_rule_language-result.xml b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_template_rule_language-result.xml index 502da4b1342..a7ecc190615 100644 --- a/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_template_rule_language-result.xml +++ b/sonar-server/src/test/resources/org/sonar/server/rule2/RegisterRulesTest/update_template_rule_language-result.xml @@ -1,6 +1,6 @@ - - - - - - - -