From b441258d1f170791208c001f1fd25bbd8f59e0ff Mon Sep 17 00:00:00 2001
From: Wouter Admiraal <wouter.admiraal@sonarsource.com>
Date: Fri, 21 Jun 2019 09:49:27 +0200
Subject: [PATCH] SONAR-12003 Fix embedded docs page title

---
 .../src/main/js/apps/documentation/components/App.tsx       | 5 ++++-
 .../components/__tests__/__snapshots__/App-test.tsx.snap    | 6 +++---
 .../src/main/resources/org/sonar/l10n/core.properties       | 3 ++-
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/documentation/components/App.tsx b/server/sonar-web/src/main/js/apps/documentation/components/App.tsx
index 00933eee7e4..ace8f8b66a8 100644
--- a/server/sonar-web/src/main/js/apps/documentation/components/App.tsx
+++ b/server/sonar-web/src/main/js/apps/documentation/components/App.tsx
@@ -56,7 +56,10 @@ export default class App extends React.PureComponent<Props> {
       : ((navigationTreeSonarQube as any).default as DocNavigationItem[]);
     const { splat = '' } = this.props.params;
     const page = this.pages.find(p => p.url === '/' + splat);
-    const mainTitle = translate('documentation.page_title');
+    const mainTitle = translate(
+      'documentation.page_title',
+      isSonarCloud() ? 'sonarcloud' : 'sonarqube'
+    );
 
     if (!page) {
       return (
diff --git a/server/sonar-web/src/main/js/apps/documentation/components/__tests__/__snapshots__/App-test.tsx.snap b/server/sonar-web/src/main/js/apps/documentation/components/__tests__/__snapshots__/App-test.tsx.snap
index 972604838ab..01b9f7beb98 100644
--- a/server/sonar-web/src/main/js/apps/documentation/components/__tests__/__snapshots__/App-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/documentation/components/__tests__/__snapshots__/App-test.tsx.snap
@@ -7,7 +7,7 @@ exports[`should render correctly for SonarCloud 1`] = `
   <HelmetWrapper
     defer={true}
     encodeSpecialCharacters={true}
-    title="Lorem | documentation.page_title"
+    title="Lorem | documentation.page_title.sonarcloud"
   />
   <ScreenPositionHelper
     className="layout-page-side-outer"
@@ -45,7 +45,7 @@ exports[`should render correctly for SonarQube 1`] = `
   <HelmetWrapper
     defer={true}
     encodeSpecialCharacters={true}
-    title="Lorem | documentation.page_title"
+    title="Lorem | documentation.page_title.sonarqube"
   >
     <meta
       content="noindex nofollow"
@@ -139,7 +139,7 @@ exports[`should show a 404 if the page doesn't exist 1`] = `
   <HelmetWrapper
     defer={true}
     encodeSpecialCharacters={true}
-    title="documentation.page_title"
+    title="documentation.page_title.sonarcloud"
   >
     <meta
       content="noindex nofollow"
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index cbc7f60daee..52c75eda331 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -2578,7 +2578,8 @@ api_documentation.search=Search by name...
 #
 #------------------------------------------------------------------------------
 documentation.page=Documentation
-documentation.page_title=SonarCloud Docs
+documentation.page_title.sonarcloud=SonarCloud Docs
+documentation.page_title.sonarqube=SonarQube Docs
 documentation.on_this_page=On this page
 documentation.skip_to_nav=Skip to documentation navigation
 
-- 
2.39.5