From b49b970b90cd9ee90bf5e414e36781f37e10315d Mon Sep 17 00:00:00 2001
From: Zipeng WU <zipeng.wu@sonarsource.com>
Date: Thu, 11 May 2023 11:50:51 +0200
Subject: [PATCH] SONAR-15440 SONAR-15441 Remove internal flag for Quality Gate
 permission management APIs

---
 .../java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java   | 1 -
 .../it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java | 1 -
 .../org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java     | 1 -
 .../java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java | 1 -
 .../org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java    | 1 -
 .../org/sonar/server/qualitygate/ws/SearchUsersActionIT.java     | 1 -
 .../java/org/sonar/server/qualitygate/ws/AddGroupAction.java     | 1 -
 .../main/java/org/sonar/server/qualitygate/ws/AddUserAction.java | 1 -
 .../java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java  | 1 -
 .../java/org/sonar/server/qualitygate/ws/RemoveUserAction.java   | 1 -
 .../java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java | 1 -
 .../java/org/sonar/server/qualitygate/ws/SearchUsersAction.java  | 1 -
 12 files changed, 12 deletions(-)

diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java
index 6b96277d189..838bf13b26d 100644
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddGroupActionIT.java
@@ -63,7 +63,6 @@ public class AddGroupActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("add_group");
     assertThat(def.isPost()).isTrue();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("groupName", "gateName");
   }
 
diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java
index b9b63c51cd6..55f53c200ea 100644
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/AddUserActionIT.java
@@ -59,7 +59,6 @@ public class AddUserActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("add_user");
     assertThat(def.isPost()).isTrue();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("login", "gateName");
   }
 
diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java
index 6d6c0b32bab..8ab0a2438cf 100644
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveGroupActionIT.java
@@ -56,7 +56,6 @@ public class RemoveGroupActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("remove_group");
     assertThat(def.isPost()).isTrue();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("groupName", "gateName");
   }
 
diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java
index b9ddfa2c8ad..e1ea8f01a80 100644
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/RemoveUserActionIT.java
@@ -56,7 +56,6 @@ public class RemoveUserActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("remove_user");
     assertThat(def.isPost()).isTrue();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key).containsExactlyInAnyOrder("login", "gateName");
   }
 
diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java
index 2227ebbad1d..ed3491cb6a0 100644
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchGroupsActionIT.java
@@ -64,7 +64,6 @@ public class SearchGroupsActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("search_groups");
     assertThat(def.isPost()).isFalse();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key)
       .containsExactlyInAnyOrder("gateName", "selected", "q", "p", "ps");
   }
diff --git a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchUsersActionIT.java b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchUsersActionIT.java
index ced09386a53..b42f0f73398 100644
--- a/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchUsersActionIT.java
+++ b/server/sonar-webserver-webapi/src/it/java/org/sonar/server/qualitygate/ws/SearchUsersActionIT.java
@@ -64,7 +64,6 @@ public class SearchUsersActionIT {
     WebService.Action def = ws.getDef();
     assertThat(def.key()).isEqualTo("search_users");
     assertThat(def.isPost()).isFalse();
-    assertThat(def.isInternal()).isTrue();
     assertThat(def.params()).extracting(WebService.Param::key)
       .containsExactlyInAnyOrder("gateName", "selected", "q", "p", "ps");
   }
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddGroupAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddGroupAction.java
index b36fe28f29c..09977a698fc 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddGroupAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddGroupAction.java
@@ -49,7 +49,6 @@ public class AddGroupAction extends AbstractGroupAction {
         "</ul>")
       .setHandler(this)
       .setPost(true)
-      .setInternal(true)
       .setSince("9.2");
 
     super.defineGateAndGroupParameters(action);
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddUserAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddUserAction.java
index e6c815ae0e8..563d946a14e 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddUserAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/AddUserAction.java
@@ -50,7 +50,6 @@ public class AddUserAction extends AbstractUserAction {
         "</ul>")
       .setHandler(this)
       .setPost(true)
-      .setInternal(true)
       .setSince("9.2");
 
     super.defineGateAndUserParameters(action);
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java
index a495428b6a1..3aa0eba9e64 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveGroupAction.java
@@ -45,7 +45,6 @@ public class RemoveGroupAction extends AbstractGroupAction {
         "</ul>")
       .setHandler(this)
       .setPost(true)
-      .setInternal(true)
       .setSince("9.2");
 
     super.defineGateAndGroupParameters(action);
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveUserAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveUserAction.java
index 083d1a63d30..fdbcfcd3869 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveUserAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/RemoveUserAction.java
@@ -45,7 +45,6 @@ public class RemoveUserAction extends AbstractUserAction {
         "</ul>")
       .setHandler(this)
       .setPost(true)
-      .setInternal(true)
       .setSince("9.2");
 
     super.defineGateAndUserParameters(action);
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java
index 314446b9466..e8478ede9e9 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchGroupsAction.java
@@ -75,7 +75,6 @@ public class SearchGroupsAction implements QualityGatesWsAction {
         "  <li>Edit right on the specified quality gate</li>" +
         "</ul>")
       .setHandler(this)
-      .setInternal(true)
       .addSelectionModeParam()
       .addSearchQuery("sonar", "group names")
       .addPagingParams(25)
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchUsersAction.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchUsersAction.java
index 1e81fe02336..baaf7177278 100644
--- a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchUsersAction.java
+++ b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/qualitygate/ws/SearchUsersAction.java
@@ -80,7 +80,6 @@ public class SearchUsersAction implements QualityGatesWsAction {
         "  <li>Edit right on the specified quality gate</li>" +
         "</ul>")
       .setHandler(this)
-      .setInternal(true)
       .addSearchQuery("freddy", "names", "logins")
       .addSelectionModeParam()
       .addPagingParams(25)
-- 
2.39.5