From b7f6de88556c006cd2bdafb6941ddb69162aaed8 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Sat, 6 Apr 2013 19:48:07 +0200 Subject: [PATCH] Fix some quality flaws --- .../sonar/runner/impl/IsolatedClassloader.java | 16 ---------------- .../main/java/org/sonar/runner/impl/Jars30.java | 1 - .../main/java/org/sonar/runner/impl/Jars35.java | 2 +- 3 files changed, 1 insertion(+), 18 deletions(-) diff --git a/sonar-runner-impl/src/main/java/org/sonar/runner/impl/IsolatedClassloader.java b/sonar-runner-impl/src/main/java/org/sonar/runner/impl/IsolatedClassloader.java index 68f390d..954b341 100644 --- a/sonar-runner-impl/src/main/java/org/sonar/runner/impl/IsolatedClassloader.java +++ b/sonar-runner-impl/src/main/java/org/sonar/runner/impl/IsolatedClassloader.java @@ -53,22 +53,6 @@ class IsolatedClassloader extends URLClassLoader { } } - /** - * {@inheritDoc} Visibility of a method has been relaxed to public. - */ - @Override - public void addURL(URL url) { - super.addURL(url); - } - - /** - * {@inheritDoc} Visibility of a method has been relaxed to public. - */ - @Override - public Class findClass(String name) throws ClassNotFoundException { - return super.findClass(name); - } - /** * @return true, if class can be loaded from parent ClassLoader */ diff --git a/sonar-runner-impl/src/main/java/org/sonar/runner/impl/Jars30.java b/sonar-runner-impl/src/main/java/org/sonar/runner/impl/Jars30.java index 274bbd7..f4d9848 100644 --- a/sonar-runner-impl/src/main/java/org/sonar/runner/impl/Jars30.java +++ b/sonar-runner-impl/src/main/java/org/sonar/runner/impl/Jars30.java @@ -20,7 +20,6 @@ package org.sonar.runner.impl; import java.io.File; -import java.io.IOException; import java.util.ArrayList; import java.util.List; diff --git a/sonar-runner-impl/src/main/java/org/sonar/runner/impl/Jars35.java b/sonar-runner-impl/src/main/java/org/sonar/runner/impl/Jars35.java index ff3bbdc..0c03a4f 100644 --- a/sonar-runner-impl/src/main/java/org/sonar/runner/impl/Jars35.java +++ b/sonar-runner-impl/src/main/java/org/sonar/runner/impl/Jars35.java @@ -70,7 +70,7 @@ class Jars35 { if (!"".equals(line)) { String[] libAndHash = line.split("\\|"); String filename = libAndHash[0]; - String hash = libAndHash.length > 0 ? libAndHash[1] : null; + String hash = libAndHash.length > 0 ? libAndHash[1] : ""; files.add(fileCache.get(filename, hash, batchFileDownloader)); } } -- 2.39.5