From b81f60728bcad3bbb55d28129720f1db11eae1f7 Mon Sep 17 00:00:00 2001
From: David Gageot <david@gageot.net>
Date: Mon, 21 May 2012 16:21:22 +0200
Subject: [PATCH] Empty widgets shouldn't be displayed

---
 .../app/views/dashboard/_widget.html.erb      | 42 ++++++++++---------
 .../app/views/dashboard/index.html.erb        | 12 +++---
 2 files changed, 28 insertions(+), 26 deletions(-)

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/_widget.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/_widget.html.erb
index 8996cf2e686..6f9e706d922 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/_widget.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/_widget.html.erb
@@ -1,27 +1,31 @@
 <% widget_body=widget_body(widget) %>
 
-<%= render :partial => 'widget_title', :locals => {:widget => widget} -%>
+<% if widget_body.include?('<') %>
+  <div class="block" id="block_<%= widget.id -%>">
+    <%= render :partial => 'widget_title', :locals => {:widget => widget} -%>
 
-<div class="<%= h widget.key -%>" style="height:100%;">
-  <% if widget.configured %>
-    <% if widget_body.include?('<')
-         default_layout=(widget.java_definition.getWidgetLayout().name()=='DEFAULT')
-         if default_layout %>
-        <div class="widget">
-      <% end %>
-      <%= widget_body -%>
+    <div class="<%= h widget.key -%>" style="height:100%;">
+      <% default_layout=(widget.java_definition.getWidgetLayout().name()=='DEFAULT') %>
       <% if default_layout %>
-        <div class="clear"></div>
+        <div class="widget">
+          <%= widget_body -%>
+          <div class="clear"></div>
         </div>
+      <% else %>
+        <%= widget_body -%>
       <% end %>
-    <% end %>
-  <% else %>
-    <div class="widget">
-      <p>
-        <a href="<%= url_for(dashboard_action(:configure)) -%>"><%= message('dashboard.please_configure_the_widget_x', :params => widget.java_definition.getTitle()) -%></a>
-      </p>
+
+      <div style="clear: both;"></div>
     </div>
-  <% end %>
-  <div style="clear: both;"></div>
-</div>
+  </div>
+<% elsif !widget.configured %>
+  <div class="block" id="block_<%= widget.id -%>">
+    <div class="<%= h widget.key -%>" style="height:100%;">
+      <div class="widget">
+        <a href="<%= url_for(dashboard_action(:configure)) -%>"><%= message('dashboard.please_configure_the_widget_x', :params => widget.java_definition.getTitle()) -%></a>
+      </div>
 
+      <div style="clear: both;"></div>
+    </div>
+  </div>
+<% end %>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/index.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/index.html.erb
index 83b795b23ed..2c62c6650af 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/index.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/index.html.erb
@@ -13,13 +13,11 @@
                widget_definition=@authorized_widget_definitions.find { |wd| wd.getId()==widget.widget_key }
                if widget_definition
           %>
-              <div class="block" id="block_<%= widget.id -%>">
-                <%= render :partial => 'widget', :locals => {:widget => widget} %>
-              </div>
-            <%
-               end
-               end
-            %>
+              <%= render :partial => 'widget', :locals => {:widget => widget} %>
+          <%
+             end
+             end
+          %>
         </div>
       </div>
     <% end %>
-- 
2.39.5