From b836e3afc424fdb1db06f5e088ab179e611c63e9 Mon Sep 17 00:00:00 2001 From: Stas Vilchik Date: Fri, 21 Sep 2018 15:32:45 +0200 Subject: [PATCH] SONARCLOUD-43 always render step form (avoids reload of billing form) --- .../OrganizationDetailsStep-test.tsx.snap | 54 +- .../__snapshots__/PlanStep-test.tsx.snap | 170 ++--- .../js/apps/tutorials/components/Step.tsx | 3 +- .../OrganizationStep-test.tsx.snap | 332 +++++----- .../__snapshots__/Step-test.tsx.snap | 15 +- .../__snapshots__/TokenStep-test.tsx.snap | 604 +++++++++--------- 6 files changed, 634 insertions(+), 544 deletions(-) diff --git a/server/sonar-web/src/main/js/apps/create/organization/__tests__/__snapshots__/OrganizationDetailsStep-test.tsx.snap b/server/sonar-web/src/main/js/apps/create/organization/__tests__/__snapshots__/OrganizationDetailsStep-test.tsx.snap index d122f4cc2fb..c792c9ff872 100644 --- a/server/sonar-web/src/main/js/apps/create/organization/__tests__/__snapshots__/OrganizationDetailsStep-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/create/organization/__tests__/__snapshots__/OrganizationDetailsStep-test.tsx.snap @@ -29,22 +29,26 @@ exports[`should render form 2`] = `
- + + isInitialValid={false} + onSubmit={[MockFunction]} + validate={[Function]} + /> +
`; @@ -187,5 +191,27 @@ exports[`should render result 1`] = `
+
+
+ +
+
`; diff --git a/server/sonar-web/src/main/js/apps/create/organization/__tests__/__snapshots__/PlanStep-test.tsx.snap b/server/sonar-web/src/main/js/apps/create/organization/__tests__/__snapshots__/PlanStep-test.tsx.snap index 216b6f565a3..099c34d7256 100644 --- a/server/sonar-web/src/main/js/apps/create/organization/__tests__/__snapshots__/PlanStep-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/create/organization/__tests__/__snapshots__/PlanStep-test.tsx.snap @@ -29,15 +29,19 @@ exports[`should preselect paid plan 2`] = `
- +
- + + + - +
`; @@ -71,25 +75,29 @@ exports[`should render and use free plan 2`] = `
- - -
- +
+ + +
- my_account.create_organization - -
-
+ + my_account.create_organization + +
+ +
`; @@ -111,20 +119,24 @@ exports[`should upgrade using card 1`] = `
- - +
- + + + - +
`; @@ -146,27 +158,31 @@ exports[`should upgrade using card 2`] = `
- - +
- - + + + + - +
`; @@ -188,20 +204,24 @@ exports[`should upgrade using coupon 1`] = `
- - +
- + + + - +
`; @@ -223,26 +243,30 @@ exports[`should upgrade using coupon 2`] = `
- - +
- - + + + + - +
`; diff --git a/server/sonar-web/src/main/js/apps/tutorials/components/Step.tsx b/server/sonar-web/src/main/js/apps/tutorials/components/Step.tsx index 7fda3877528..4a3dfc68860 100644 --- a/server/sonar-web/src/main/js/apps/tutorials/components/Step.tsx +++ b/server/sonar-web/src/main/js/apps/tutorials/components/Step.tsx @@ -55,7 +55,8 @@ export default function Step(props: Props) {

{props.stepTitle}

- {props.open ? props.renderForm() :
} + {!props.open &&
} +
{props.renderForm()}
); } diff --git a/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/OrganizationStep-test.tsx.snap b/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/OrganizationStep-test.tsx.snap index 8ece74c899f..9b0573150aa 100644 --- a/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/OrganizationStep-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/OrganizationStep-test.tsx.snap @@ -53,50 +53,35 @@ exports[`works with existing organization 1`] = `
- onboarding.organization.text -
-
- - - onboarding.organization.exising_organization - + onboarding.organization.text +
+
- -
- -
- Select... -
-
- + > + +
+
+ +
- + > + + +
-
- - - + + + +
-
-
- - - onboarding.organization.create_another_organization - + + + onboarding.organization.create_another_organization + +
diff --git a/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/Step-test.tsx.snap b/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/Step-test.tsx.snap index 4667ca7ae8a..1e188e0d498 100644 --- a/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/Step-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/Step-test.tsx.snap @@ -16,8 +16,12 @@ exports[`renders 1`] = ` First Step -
- form +
+
+ form +
`; @@ -47,5 +51,12 @@ exports[`renders 2`] = `
+
+
+ form +
+
`; diff --git a/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/TokenStep-test.tsx.snap b/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/TokenStep-test.tsx.snap index 54847972e8c..b502318ad8d 100644 --- a/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/TokenStep-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/tutorials/components/__tests__/__snapshots__/TokenStep-test.tsx.snap @@ -38,78 +38,82 @@ exports[`generates token 1`] = `
-
@@ -154,61 +158,65 @@ exports[`generates token 2`] = `
-
+
- - - onboarding.token.generate_token - +
-
- - + onboarding.token.use_existing_token +
-
- onboarding.token.text -
@@ -253,77 +261,81 @@ exports[`generates token 3`] = `
-
- - my token - : - - - abcd1234 - - - + my token + : + + + abcd1234 + + - - - - -
-
- onboarding.token.text -
-
- + + + + +
- - + + +
@@ -369,77 +381,81 @@ exports[`revokes token 1`] = `
-
- - my token - : - - - abcd1234 - - - + my token + : + + + abcd1234 + + - - - - -
-
- onboarding.token.text -
-
- + + + + +
- - + + +
@@ -485,46 +501,50 @@ exports[`revokes token 2`] = `
-
- - my token - : - - + my token + : + + + abcd1234 + + + +
- abcd1234 - - - -
- onboarding.token.text -
-
- - + + +
@@ -570,78 +590,82 @@ exports[`revokes token 3`] = ` -- 2.39.5