From b8bfebe51e6d4c007a6dcd3fcb56e4684704af24 Mon Sep 17 00:00:00 2001 From: kondou Date: Tue, 6 Aug 2013 17:26:12 +0200 Subject: [PATCH] Use setUpBeforeClass() and tearDownAfterClass() --- tests/lib/preferences.php | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/lib/preferences.php b/tests/lib/preferences.php index a1719c92b29..18e1cde8488 100644 --- a/tests/lib/preferences.php +++ b/tests/lib/preferences.php @@ -7,7 +7,7 @@ */ class Test_Preferences extends PHPUnit_Framework_TestCase { - private function fillDb() { + public static function setUpBeforeClass() { $query = \OC_DB::prepare('INSERT INTO `*PREFIX*preferences` VALUES(?, ?, ?, ?)'); $query->execute(array("Someuser", "someapp", "somekey", "somevalue")); @@ -28,7 +28,7 @@ class Test_Preferences extends PHPUnit_Framework_TestCase { $query->execute(array("Deleteuser", "someapp", "somekey", "somevalue")); } - private function cleanDb() { + public static function tearDownAfterClass() { $query = \OC_DB::prepare('DELETE FROM `*PREFIX*preferences` WHERE `user` = ?'); $query->execute(array('Someuser')); $query->execute(array('Anotheruser')); @@ -36,8 +36,6 @@ class Test_Preferences extends PHPUnit_Framework_TestCase { } public function testGetUsers() { - $this->fillDb(); - $query = \OC_DB::prepare('SELECT DISTINCT `userid` FROM `*PREFIX*preferences`'); $result = $query->execute(); $expected = array(); @@ -124,7 +122,5 @@ class Test_Preferences extends PHPUnit_Framework_TestCase { $query = \OC_DB::prepare('SELECT `configvalue` FROM `*PREFIX*preferences` WHERE `appid` = ?'); $result = $query->execute(array('someapp')); $this->assertEquals(0, $result->numRows()); - - $this->cleanDb(); } } -- 2.39.5