From b8d0d54a3c4960794a1b492957abeb56eddd1e48 Mon Sep 17 00:00:00 2001 From: Chris Antaki Date: Tue, 5 Nov 2013 21:23:04 -0800 Subject: [PATCH] Reduce size by reordering variable declarations Close gh-1421 --- src/attributes/classes.js | 8 ++++---- src/core/access.js | 6 +++--- src/effects.js | 8 ++++---- src/traversing/findFilter.js | 11 ++++++----- 4 files changed, 17 insertions(+), 16 deletions(-) diff --git a/src/attributes/classes.js b/src/attributes/classes.js index d7212f9de..7d714b8e1 100644 --- a/src/attributes/classes.js +++ b/src/attributes/classes.js @@ -11,9 +11,9 @@ var rclass = /[\t\r\n\f]/g; jQuery.fn.extend({ addClass: function( value ) { var classes, elem, cur, clazz, j, finalValue, + proceed = typeof value === "string" && value, i = 0, - len = this.length, - proceed = typeof value === "string" && value; + len = this.length; if ( jQuery.isFunction( value ) ) { return this.each(function( j ) { @@ -54,9 +54,9 @@ jQuery.fn.extend({ removeClass: function( value ) { var classes, elem, cur, clazz, j, finalValue, + proceed = arguments.length === 0 || typeof value === "string" && value, i = 0, - len = this.length, - proceed = arguments.length === 0 || typeof value === "string" && value; + len = this.length; if ( jQuery.isFunction( value ) ) { return this.each(function( j ) { diff --git a/src/core/access.js b/src/core/access.js index 97b410b40..b6110c8f3 100644 --- a/src/core/access.js +++ b/src/core/access.js @@ -6,7 +6,7 @@ define([ // The value/s can optionally be executed if it's a function var access = jQuery.access = function( elems, fn, key, value, chainable, emptyGet, raw ) { var i = 0, - length = elems.length, + len = elems.length, bulk = key == null; // Sets many values @@ -40,7 +40,7 @@ var access = jQuery.access = function( elems, fn, key, value, chainable, emptyGe } if ( fn ) { - for ( ; i < length; i++ ) { + for ( ; i < len; i++ ) { fn( elems[i], key, raw ? value : value.call( elems[i], i, fn( elems[i], key ) ) ); } } @@ -52,7 +52,7 @@ var access = jQuery.access = function( elems, fn, key, value, chainable, emptyGe // Gets bulk ? fn.call( elems ) : - length ? fn( elems[0], key ) : emptyGet; + len ? fn( elems[0], key ) : emptyGet; }; return access; diff --git a/src/effects.js b/src/effects.js index cbf098d1a..b439d8d58 100644 --- a/src/effects.js +++ b/src/effects.js @@ -82,8 +82,8 @@ function createFxNow() { // Generate parameters to create a standard animation function genFx( type, includeWidth ) { var which, - attrs = { height: type }, - i = 0; + i = 0, + attrs = { height: type }; // if we include width, step value is 1 to do all cssExpand values, // if we don't include width, step value is 2 to skip over Left and Right @@ -590,8 +590,8 @@ jQuery.each({ jQuery.timers = []; jQuery.fx.tick = function() { var timer, - timers = jQuery.timers, - i = 0; + i = 0, + timers = jQuery.timers; fxNow = jQuery.now(); diff --git a/src/traversing/findFilter.js b/src/traversing/findFilter.js index 71fe52aaf..f903ac715 100644 --- a/src/traversing/findFilter.js +++ b/src/traversing/findFilter.js @@ -53,14 +53,14 @@ jQuery.filter = function( expr, elems, not ) { jQuery.fn.extend({ find: function( selector ) { - var i, + var i = 0, + len = this.length, ret = [], - self = this, - len = self.length; + self = this; if ( typeof selector !== "string" ) { return this.pushStack( jQuery( selector ).filter(function() { - for ( i = 0; i < len; i++ ) { + for ( ; i < len; i++ ) { if ( jQuery.contains( self[ i ], this ) ) { return true; } @@ -68,7 +68,8 @@ jQuery.fn.extend({ }) ); } - for ( i = 0; i < len; i++ ) { + i = 0; + for ( ; i < len; i++ ) { jQuery.find( selector, self[ i ], ret ); } -- 2.39.5