From ba0e65753b82a91d5145955aee0624876dee3ce4 Mon Sep 17 00:00:00 2001 From: Clark Tomlinson Date: Tue, 26 Aug 2014 09:40:56 -0400 Subject: [PATCH] Init vars with a value if none is provided --- core/js/js.js | 1 + core/js/tests/specs/coreSpec.js | 3 +++ 2 files changed, 4 insertions(+) diff --git a/core/js/js.js b/core/js/js.js index 60f9cc11a58..2f02ccd04a8 100644 --- a/core/js/js.js +++ b/core/js/js.js @@ -234,6 +234,7 @@ var OC={ */ generateUrl: function(url, params) { var _build = function (text, vars) { + var vars = vars || []; return text.replace(/{([^{}]*)}/g, function (a, b) { var r = vars[b]; diff --git a/core/js/tests/specs/coreSpec.js b/core/js/tests/specs/coreSpec.js index 166210d0312..3af56c490e6 100644 --- a/core/js/tests/specs/coreSpec.js +++ b/core/js/tests/specs/coreSpec.js @@ -376,6 +376,9 @@ describe('Core base tests', function() { it('substitutes parameters', function() { expect(OC.generateUrl('apps/files/download{file}', {file: '/Welcome.txt'})).toEqual(OC.webroot + '/index.php/apps/files/download/Welcome.txt'); }); + it('doesnt error out with no params provided', function () { + expect(OC.generateUrl('apps/files/download{file}')).toEqual(OC.webroot + '/index.php/apps/files/download{file}'); + }); }); describe('Main menu mobile toggle', function() { var clock; -- 2.39.5