From bbc6eee8032061d3de5aced8da60e9342fd6047d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Julius=20H=C3=A4rtl?= Date: Fri, 3 Mar 2023 09:40:43 +0100 Subject: [PATCH] fix: Avoid log spam on 404 routes not using GET MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- lib/base.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/base.php b/lib/base.php index b5c5845b5a0..be931e70d55 100644 --- a/lib/base.php +++ b/lib/base.php @@ -80,6 +80,7 @@ use OCP\Server; use OCP\Share; use OCP\User\Events\UserChangedEvent; use Psr\Log\LoggerInterface; +use Symfony\Component\Routing\Exception\MethodNotAllowedException; use function OCP\Log\logger; require_once 'public/Constants.php'; @@ -1097,7 +1098,9 @@ class OC { try { Server::get(\OC\Route\Router::class)->match('/error/404'); } catch (\Exception $e) { - logger('core')->emergency($e->getMessage(), ['exception' => $e]); + if (!$e instanceof MethodNotAllowedException) { + logger('core')->emergency($e->getMessage(), ['exception' => $e]); + } $l = Server::get(\OCP\L10N\IFactory::class)->get('lib'); OC_Template::printErrorPage( $l->t('404'), -- 2.39.5