From bd60c5a1bc2f389991e796245795bd11fc4e5104 Mon Sep 17 00:00:00 2001
From: Julien Lancelot <julien.lancelot@sonarsource.com>
Date: Thu, 30 Jan 2014 17:15:40 +0100
Subject: [PATCH] SONAR-4920 A dashboard should never have an un-configured
 widget

---
 .../app/views/dashboard/_widget.html.erb      | 21 +++++++++----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/_widget.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/_widget.html.erb
index 38b348df389..b706fd19076 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/_widget.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/dashboard/_widget.html.erb
@@ -4,8 +4,17 @@
   default_layout=(widget.java_definition.getWidgetLayout().name()=='DEFAULT')
 %>
 
-<% if !widget_body %>
+<% if !widget.configured %>
+<div class="block">
+  <div class="widget">
+    <span class="empty_widget">
+      <a class="note" href="<%= url_for(dashboard_action(:configure)) -%>"><%= message('dashboard.please_configure_the_widget_x', :params => widget.java_definition.getTitle()) -%></a>
+    </span>
+    <div class="clear"></div>
+  </div>
+</div>
 
+<% elsif !widget_body %>
   <div class="block">
    <% if default_layout %>
      <div class="widget">   
@@ -31,16 +40,6 @@
         <%= widget_body -%>
       <% end %>
 
-      <div style="clear: both;"></div>
-    </div>
-  </div>
-<% elsif !widget.configured %>
-  <div class="block" id="block_<%= widget.id -%>">
-    <div class="<%= h widget.key -%>" style="height:100%;">
-      <div class="widget">
-        <a href="<%= url_for(dashboard_action(:configure)) -%>"><%= message('dashboard.please_configure_the_widget_x', :params => widget.java_definition.getTitle()) -%></a>
-      </div>
-
       <div style="clear: both;"></div>
     </div>
   </div>
-- 
2.39.5