From bdb21c18c2ac04c2f3664260a04ee9ba6b93a988 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Wed, 19 Jun 2013 08:11:06 +0200 Subject: [PATCH] SONAR-4394 Improve authorization to modify issue filters --- .../main/java/org/sonar/server/issue/IssueFilterService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java b/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java index 8be218777e8..ae455c438ff 100644 --- a/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java +++ b/sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java @@ -174,7 +174,7 @@ public class IssueFilterService implements ServerComponent { } private void verifyCurrentUserCanModifyFilter(IssueFilterDto issueFilterDto, UserSession userSession) { - if (!issueFilterDto.getUserLogin().equals(userSession.login()) && (!issueFilterDto.isShared() || !isAdmin(userSession.login()))) { + if (!issueFilterDto.getUserLogin().equals(userSession.login()) && !isAdmin(userSession.login())) { // TODO throw unauthorized throw new IllegalStateException("User is not authorized to modify this filter"); } -- 2.39.5