From be9f7f3128a2f4c895f595058a2f53af1bc91778 Mon Sep 17 00:00:00 2001 From: Teemu Suo-Anttila Date: Wed, 10 Jun 2015 15:34:45 +0300 Subject: [PATCH] Fix Escalator spacer visibility calucation (#17826) Now calls directly to correct spacer container to update visibility instead of doing extra work with recalculating everything. Change-Id: I8625033012773a10983cd5d4f6ef3ce1be50ee26 --- client/src/com/vaadin/client/widgets/Escalator.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/client/src/com/vaadin/client/widgets/Escalator.java b/client/src/com/vaadin/client/widgets/Escalator.java index 45c8267d53..3990683e64 100644 --- a/client/src/com/vaadin/client/widgets/Escalator.java +++ b/client/src/com/vaadin/client/widgets/Escalator.java @@ -1278,7 +1278,7 @@ public class Escalator extends Widget implements RequiresResize, *

* The implementation must call {@link #paintRemoveRow(Element, int)} * for each row that is removed from the DOM. - * + * * @param index * the logical index of the first removed row * @param numberOfRows @@ -4994,7 +4994,8 @@ public class Escalator extends Widget implements RequiresResize, spacerScrollerRegistration.removeHandler(); spacerScrollerRegistration = null; } - recalculateElementSizes(); + + updateSpacerDecosVisibility(); } public Map getSpacers() { @@ -5305,7 +5306,7 @@ public class Escalator extends Widget implements RequiresResize, initSpacerContent(spacer); body.sortDomElements(); - recalculateElementSizes(); + updateSpacerDecosVisibility(); } private void updateExistingSpacer(int rowIndex, double newHeight) { @@ -6286,7 +6287,6 @@ public class Escalator extends Widget implements RequiresResize, body.recalculateSectionHeight(); footer.recalculateSectionHeight(); - body.spacerContainer.updateSpacerDecosVisibility(); scroller.recalculateScrollbarsForVirtualViewport(); body.verifyEscalatorCount(); body.reapplySpacerWidths(); -- 2.39.5