From c005313b3dd0dddff09bcb057ec9c90f981f8157 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Wed, 18 Mar 2015 15:04:49 +0100 Subject: [PATCH] Fix quality flaws --- .../org/sonar/server/db/migrations/AddColumnsBuilder.java | 6 +----- .../main/java/org/sonar/server/db/migrations/DdlChange.java | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/AddColumnsBuilder.java b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/AddColumnsBuilder.java index 8d884296c8f..34aca9d0e41 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/AddColumnsBuilder.java +++ b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/AddColumnsBuilder.java @@ -91,11 +91,7 @@ public class AddColumnsBuilder { case STRING: return "VARCHAR"; case BIG_INTEGER: - if (dialect.getId().equals(Oracle.ID)) { - return "NUMBER (38)"; - } else { - return "BIGINT"; - } + return !dialect.getId().equals(Oracle.ID) ? "BIGINT" : "NUMBER (38)"; default: throw new IllegalArgumentException("Unsupported type : " + columnDef.getType()); } diff --git a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/DdlChange.java b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/DdlChange.java index 6dafe50ec1b..39944bae8e7 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/db/migrations/DdlChange.java +++ b/server/sonar-server/src/main/java/org/sonar/server/db/migrations/DdlChange.java @@ -47,7 +47,7 @@ public abstract class DdlChange implements DatabaseMigration { } } - public class Context { + public static class Context { private final Connection writeConnection; public Context(Connection writeConnection) { -- 2.39.5