From c04ddf554f3f2c77e268468a43dd645a8b565074 Mon Sep 17 00:00:00 2001 From: Florian Zschocke Date: Mon, 21 Nov 2022 21:14:56 +0100 Subject: [PATCH] Remove clippy.swf and update documentation The `clippy.swf` Flash program is no longer needed and can be deleted. The configuration property is now incorrectly named, but we keep the name and update the documentation. Maybe it could be completely deleted one day, when the clipboard.js solution is known to work and be universally supported. --- releases.moxie | 9 ++++++++- src/main/distrib/data/defaults.properties | 6 +++++- src/main/resources/clippy.swf | Bin 5380 -> 0 bytes 3 files changed, 13 insertions(+), 2 deletions(-) delete mode 100644 src/main/resources/clippy.swf diff --git a/releases.moxie b/releases.moxie index 05ac21e8..4e8006ff 100644 --- a/releases.moxie +++ b/releases.moxie @@ -7,6 +7,11 @@ r34: { date: ${project.buildDate} note: '' From 1.10.0 on Gitblit requires Java 8 as minimum Java version. + + Should you have disabled the Flash-based copy-to-clipboard function because it wasn't working anymore + (web.allowFlashCopyToClipboard = false), you may want to rethink this and enable it again. The configuration + property has the same name, but the mechanism was exchanged. Flash is gone, and a modern JavaScript solution + is now used to copy text directly to the clipboard (via clipboard.js). '' html: ~ text: ~ @@ -14,7 +19,8 @@ r34: { fixes: - Fix crash in Gitblit Authority when users were deleted from Gitblit but still had entries (certificates) in the Authority. changes: - - Minimum Java required increased to Java 8 + - Minimum Java required increased to Java 8. + - Replaced the Flash-based approach to copy text to the clipboard with a modern JavaScript solution. (issue-1241) additions: ~ dependencyChanges: - update to JavaMail 1.5.6 (pr-1217 by @paladox) @@ -24,6 +30,7 @@ r34: { - update to Apache commons-io 2.11.0 - update to Apache commons-compress 1.22 - update to libpam4j 1.11 + - added clipboard.js, replacing clippy.swf contributors: - paladox } diff --git a/src/main/distrib/data/defaults.properties b/src/main/distrib/data/defaults.properties index 0d072b58..b62285fd 100644 --- a/src/main/distrib/data/defaults.properties +++ b/src/main/distrib/data/defaults.properties @@ -1076,7 +1076,11 @@ web.allowForking = true # SINCE 1.2.0 web.shortCommitIdLength = 6 -# Use Clippy (Flash solution) to provide a copy-to-clipboard button. +# Use a JavaScript browser API to provide a copy-to-clipboard button. +# The clipboard.js library is used to copy text directly to the browser's +# clipboard. +# (This used to be done with a Flash based solution, but has been replaced +# with a modern JavaScript approach, since Flash support is dying out.) # If false, a button with a more primitive JavaScript-based prompt box will # offer a 3-step (click, ctrl+c, enter) copy-to-clipboard alternative. # diff --git a/src/main/resources/clippy.swf b/src/main/resources/clippy.swf deleted file mode 100644 index e46886cd1153122af2f216a6a86cbd816615d54d..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 5380 zcmV+f75nN#S5pc08vp=!+LTy%SX4*0zjgcet=@ocKrjm0DA0h7;D)H64M+njAhL)H z(A#ZpYcJS+X~pQ+A|i-O)EJXE#4VG=F`C867bgadCKG+5Q5v30MxzYP*OoT}T)C=@|a)CMSsny!*SJ54I3DT=1Vp;Rcf>>nGq zezbVblEJ6?!piPkmoyvxvS{1E`3oM)X+Qm5$2&(iI5P(Ss6U}z%3S%3mtVj9-eGgv zxeMV-$~Rv=;dwT#_uQ-(<2%cn4K*vK9QQ0a)OGLb%Bfj*vd&NHEIBprVAYX@hsr*7 zWL#>3~URn2?0!|g9L-&oX{wBGP!)AfDdXZ~21_x`vw|BfC0-Tutb zZDsM-{P%uMSlf^}YvI8Im%cO%tINq2!rs2rvL?FxW4Y}=hfI5CJM-i+)LDXGtKM*A z{@nc)uYP%~<%`c^8_w+5B9!iay6DD&zpl^SLp{a$`SHs3>1_uZo7KMBA$i|SQ`(@^)cW)n_6j`_P#Id*5Z@yi0$1Xem{B{1#D_>kY z{WZOsTJpxBYVD2BBR2l@TmFhWX@+fXv*W_LuRD`+_dM~%w$9m+`3rlVSS2d%{o-ty zVQ}lOABxwUP*0B8RMz+Gkx%sdzMYoUlk;E4sc3Kt5tS5!DU<`AK`A2-Egd`W^|Ri^ zzCP)Yfaf6UII94}BB1~Ph6yUdho%@QyKdQjVhERrg!J2ZeNsFl$`!<=D7{;7M!p#adDLswZgZV zKaIA2aO10UO`d7jA`-V137Ii>mUq3Yp3-@4oAvNt?QdRDZ9Y}DzoNC7`|zzZpZ@&y zx69sH5_8Wq?AALg-#$KZy<*(Pu=Dk*yXTFrQL;TJb0YKC-`?8lZB`r1#$lgU4*i4m zn~!&W_HNzA)koaY$7deC9Qv=gGh_3YZrpUX=wGM0ul#lGyKi*7bo{xKMnm}gh9MX3 zWc8%Eaw{v>-yYJrH>of?=2Y1i?4Q5+Z1>AG@1OWiAv+uCE=^P}_YSQ~kZ#>{dq~Z} zs@|hxR@A?ex6*@tIjivA7?pIhC&@C;lCkaH4^7cq3R{loFWED0P1@;S{KO8;tG_G@ zAG@ny-(At(=XF~L2}f(X*Ov9$f{gDqSJ+cD(=D*68!M=c}26 z9}oXfd3@ZOvwCIB&b+C+F718&J%83%%_qAGCRk5R{5IpaACrE)wRU#LA5UHRbW-<; zFOwo=^DC-;g6Ped(EiPoi4Bpv@*e+S{l2@lAGRLmv%6aUaveQ)^Np8YzP)8q(--59 zMIPF-{Vkt$#jtOx?3csl#by8T2FF*V`cF3smq_pCFd%oJ+`|tJhyV{rUYyW3Mn=rY! z`lE<^)zvQPUnZvQje5GJu=B);=i0&!W<=(%)}Hy?d$cfdTg!#6Ir|ysxA9XCUHSI6 z6HIMd_3p2Z<#si-&G^&aKlR>HZz)t({q*-w#}4k(hVJ#A-h6&fVP}5cQ+GbO=~A$w zAAVW6K|k{AX&`aY);llg*3@)~op%#2((<;JT_5LLXC6)7K4bL@Hikwg!`J-~@}a%z z`ps2kzvM3Wp0td;n>FnGk*>s-|7OqV6HVALa!k;dr2W1md6X~VhkZ%>OH#y*7^xki=-QnwB$9qJuWwE6a=H0$Bhl; zf>Ge4M7ba$ss)gOx51tsA=n8D&UryikF3}Q%<>7A6qi<(=hs!v?kDgxc?8bEmIoRI zNS!yJg4k{}adr%<**HraYYk|k1W^NgX4znYlXJ_0{7S3x=ScfuWd-9f+MM!SmrJNK zWtb=G^533;zpZYjzYGTtJlXcDvkC*hUB-QG=@iH#$AM%_^{V&RH+;4Cgi4r9nxYoDkwPdTsS!$qHBH zoLLfmqti@y%AhlcTha)2W??hvNv$3b%K;}P7TiWNC(Z*F9@^-^U;sO3bV};#Y#z?p z=m@QQU;&Qk?qa6)hfYyklgQvYzEi0eE?r-!k+fYicSjg9t)CqbWj zPFzlESpd(qSp;6Zl+>#G(V5c-=CUp4m|6My3W>45r*H&9z)2#{!X`Nz?e=7e)n@02 zi=fFeqD;^p^kg-Xv2ajkvSq+Qc+OVO3-Z98g#nD~f=Ubm@yi;GcAFJ~ByjKnmuqPB z@aS=*7O8>RO0)pgNUQ@6lr?~+f~6Xr4Q`hJkx*ABCCDW-HE?2&-3A6DNrffOZRS`w zOwKK^K{JaWeTj^2x5Ne~ZG>ow2BXe)yBdI`smPNL&I9A1sLae8-FYqxmm`SGW+P)Z z+U;Txw%#eJD4ktL3?$YSL#&G6;8i901vwQ(Rrz&ACHkV0qKbK{*`?)0zZ;R*JbH5c zoIDCeiJ~M?VNr2W@lj(X8PLz6k#qyXh{iO7kr*QuBaB5-jAR(eF;ZX@f>9`Dl$cRr z6p7IwjG{1##%M4`k70TUMnf@*!6+7^VHgd^NR7oKFdB*31dI|f(qNQ~Q3^(*Fw$a_ ziqU9{(lAQLXbi^VFdC21I4qfnQ6|Qduw*huQ!vWHl58xQiqW*8Ae|1&axu!ovgsJ* zV^)t5{1;$Uh*1$nGccNo(JYLLF)G2R6rgoqjHQYFsj6;3ZuCgRbw;{qxl#u zz-S>xH5k=mRELoPBO^v8jLaBWFyb(>VpNY2kC7cC2S!eeTo^TAv;-p$Mgm5SnD%0{ z6vK_cG-0$HqsK8?fzcl@@*yl)1EmEdUkjxb$~v%W8;rFB-U?+KlqaEVhw>DZ9Z;Tz z@(h$`q3ne6M<|_8o`bRr%5Eroq3nb5Jd{5{c>(F*LZ<#7g+^#7wD+s~Qz@j8Q#6ex z$tekp&`2HxC_qBXVMs$wg>M!lPto+Rl0V=;qm&d%LOx{fGYmWo2Bvj^iNJ!C3aB&y zQ3a_|$li#iWQ0^hIBB3pI!&NU2e^;{P5-V)uIcAT2fD}vP(juOR?CT0MEL)uKhjn7 zSCm{7kd%Bzi6}80ctUH)lZJ&lj4INIsKMeqqTqC*NoJAYRC*A8cLNy z9m~u@)bN>vrkGSEh*B?r@i;00m?l%}5OgNP<_x@@WGG&RV<;w_N~FX(sz8Ot&Q{Um3@Xuhvx=EuREaYhRqVt$DxA4Y zC7Cn@!BP#_0Erkxi4nsfBtc>Z(OHrt28mdPW{Mb*cm~6;rHmLaU|2~4gQe>bBa!Lg z>lFS90;d`T;5$eZ+MRAO(CG%cnu_H`1%c0x;IwD}h<{IqVtJ+@@U#q0vjaf#dpbIn z7sIH6Y%|CZYmk)=Lx$nnBwl71Zcvwok|iNzk~IuZsXoN1LAC1(70wSCEVTS@rq^3k6)NtYkG7@I80V_(Op%vZfh6HP3IJi>* zjH$>RTa&C$rV1%4TqH%}SBNcAE~cxS&8)grZkG796ZBf-OZBB*s-k?UW=7rIY!)kX zfMd<*UYJZnKDmB0B7Q3)ThovUAH9Z{O{)Pk-%a1WJz520~PhL6>nZ)Ym2nN0o zWE9nF9q);!qTlH2i>Ewhtc(YqCdP!V6MS+XY<&_F>PQhqshbN;Vw1!=f$VLdA;QAD(`)nmd|vJJ9)5alelMS2Kq9?=#n4Bv z8#XXGTtp*U3F~Lp&a}=<@mzR^pXmp_YC5=xjMf%gix0wBEC@?SJ;bPXrk{t|9=;ej zjTC_@QbU5jM?ahP0(m^JMsgU?BK;iNCx@W~M555|0hmY!>{sd6SEA;NHB~+ODij_( zq#l^o5c}bpxqkgzqGl4|6=tY5RO{zajsCs*`G_zXF`!1=BXk@~){OC6^L?pmUn)5w zzcmlU2-I5JZl63br(G0qKIm!}?+!>gjus_B1B3U%K_QsPlNr1g;)ILQd*`96g|aLjnx)HHL&LimwH+CeT5%=#7+5;pf9( zD1(@8sk$}fB3b97FAT7%Aif_+AcTRnMsJ~fA-<4{Jz6)S+Tht82r9-vw5>HU+SLd~9-J|;VlxVax_${%d~GiwBxA(LkTgkltoQK{fMOym zF_tnKLY9z~x~cy`t|46#;3yPAJ-OHFF^R3hD_+$HeSKiKOmQeedqgC~FzVJ+vzSzD zJY~jkZW1yq)tF__mqSsIen^eiulEA)OT9!7&>%hX@8GK>bp$dK>xY#}IY}a{Nn*mo zN|&Os60Eund4h#`v35PIHcJz|gfXlFfyR40X1TJGtidO-$E<)fqv+2+AtqTkWDX6G z6Rswyc2UrVQh*)E6hch4q2G$85J*lv1C|`1!zTHleXzaksc=PrLkD`mV&el`sN4k8 zj5agU1&6okzLApP2K_01gGugb5oS%Ptzd4^kk-$#7 z1r;hGGHT@h8FCW9lSt&#B(sbeh}jepvy$%gZvAqq874+SMy2J@_s3H`r7OsFuN8?A zJ+V6-PLBZvE_PeTH(yf5fbcyhX^)xdh8#Yj*&hkM0WcnwuAmbOdwK_5>+911$I&D% zWrkG-9|FBe3QL2V8ihl@c9mfj$#%w7e&7HzsgU_aLxNX$JVh?C!6c zLW=gmgEy601y4*W9Rik)g>=(`y8ZgKh;DvF3QGpz#Xa|L!b|saQ+E+%NVPUKU+UGR z@Q?TEM)50qbz1%py}DF>HR{!FN1D=RME7cU41lKxz|J6mSBBi$WL<-r9RZ|E=hvWM zhViR?bR@}9KAPM|ejg3d%9Ux*-tbW3HP(9V9>ljIC0wg; zqa`cZ{%e@Xy-@ATj1ZG#RJxEVK<(&Fbd)@STM&8kO&K`R$&bjwQ%Sm$)^s4hz5@|Y zm=?_JRerD*bhAl!9%S~4W@{U2qEau!ZZB-Z