From c079795f4e5ac3314aec9d0dfbad77a36d5f39e8 Mon Sep 17 00:00:00 2001
From: Nick Burch <nick@apache.org>
Date: Mon, 14 May 2018 14:25:00 +0000
Subject: [PATCH] List a few more missing functions as inline-comments, based
 on definitions from functionMetadata.txt

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1831572 13f79535-47bb-0310-9956-ffa450edef68
---
 .../apache/poi/ss/formula/eval/FunctionEval.java   | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java b/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java
index ef4062e719..0c55327a4a 100644
--- a/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java
+++ b/src/java/org/apache/poi/ss/formula/eval/FunctionEval.java
@@ -138,7 +138,6 @@ public final class FunctionEval {
         retval[72] = CalendarFieldFunction.MINUTE;
         retval[73] = CalendarFieldFunction.SECOND;
         retval[74] = new Now();
-        // 75: AREAS
         retval[75] = new Areas();
         retval[76] = new Rows();
         retval[77] = new Columns();
@@ -173,12 +172,19 @@ public final class FunctionEval {
         retval[121] = new Code();
 
         retval[124] = TextFunction.FIND;
+        // 125: CELL
 
         retval[126] = LogicalFunction.ISERR;
         retval[127] = LogicalFunction.ISTEXT;
         retval[128] = LogicalFunction.ISNUMBER;
         retval[129] = LogicalFunction.ISBLANK;
         retval[130] = new T();
+        // 131: N
+        // 140: DATEVALUE
+        // 141: TIMEVALUE
+        // 142: SLN
+        // 143: SYD
+        // 144: DDB
 
         retval[FunctionID.INDIRECT] = null; // Indirect.evaluate has different signature
 
@@ -195,12 +201,15 @@ public final class FunctionEval {
         retval[183] = AggregateFunction.PRODUCT;
         retval[184] = NumericFunction.FACT;
 
+        // 189: DPRODUCT
         retval[190] = LogicalFunction.ISNONTEXT;
 
         retval[194] = AggregateFunction.VARP;
-
+        // 195: DSTDEVP
+        // 196: DVARP
         retval[197] = NumericFunction.TRUNC;
         retval[198] = LogicalFunction.ISLOGICAL;
+        // 199: DCOUNTA
 
         //204: USDOLLAR (YEN in BIFF3)
         //205: FINDB
@@ -233,6 +242,7 @@ public final class FunctionEval {
         // 244: INFO
 
         // 247: DB
+        // 252: FEQUENCY
         
         retval[FunctionID.EXTERNAL_FUNC] = null; // ExternalFunction is a FreeRefFunction, nominally 255
 
-- 
2.39.5