From c090802cc1f92736288dafbea95bb2783392975e Mon Sep 17 00:00:00 2001 From: =?utf8?q?Scott=20Gonz=C3=A1lez?= Date: Mon, 4 Oct 2010 09:18:21 -0400 Subject: [PATCH] Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7." This reverts commit 67b1db14c964418ce8b1fd760d54761040cc32af. Reverting so I can commit again with the proper author. --- tests/unit/dialog/dialog_tickets.js | 17 ----------------- ui/jquery.ui.dialog.js | 3 +++ 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/tests/unit/dialog/dialog_tickets.js b/tests/unit/dialog/dialog_tickets.js index f7b590b53..dfa480fb7 100644 --- a/tests/unit/dialog/dialog_tickets.js +++ b/tests/unit/dialog/dialog_tickets.js @@ -61,21 +61,4 @@ test("#5531: dialog width should be at least minWidth on creation", function () }); -test("#6137: dialog('open') causes form elements to reset on IE7", function() { - expect(2); - - d1 = $('
' + - 'b
').dialog({autoOpen: false}); - - d1.find('#b')[0].checked = true; - equal($('input:checked').val(), 'b', "checkbox b is checked"); - - d2 = $('
').dialog({autoOpen: false}); - - d1.dialog('open'); - equal($('input:checked').val(), 'b', "checkbox b is checked"); - - d1.add(d2).remove(); -}) - })(jQuery); diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index b000bf5bd..86dfa5fa1 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -309,6 +309,9 @@ $.widget("ui.dialog", { uiDialog = self.uiDialog; self.overlay = options.modal ? new $.ui.dialog.overlay(self) : null; + if (uiDialog.next().length) { + uiDialog.appendTo('body'); + } self._size(); self._position(options.position); uiDialog.show(options.show); -- 2.39.5